----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21428/#review42967 -----------------------------------------------------------
core/src/main/scala/kafka/api/FetchRequest.scala <https://reviews.apache.org/r/21428/#comment76927> Should isFromFollower be false if either isFromOrdinaryConsumer or isFromLowLevelConsumer is true? - Guozhang Wang On May 14, 2014, 4:40 a.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21428/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 4:40 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1450 > https://issues.apache.org/jira/browse/KAFKA-1450 > > > Repository: kafka > > > Description > ------- > > Use Node.isIdValid() instead of testing against -1. > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/Node.java > 0e47ff3ff0e055823ec5a5aa4839d25b0fac8374 > > clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java > 2652c32f123b3bc4b0456d4bc9fbba52c051724c > core/src/main/scala/kafka/api/FetchRequest.scala > a8b73acd1a813284744359e8434cb52d22063c99 > core/src/main/scala/kafka/api/RequestOrResponse.scala > 57f87a48c5e87220e7f377b23d2bbfa0d16350dc > core/src/main/scala/kafka/server/KafkaApis.scala > 0b668f230c8556fdf08654ce522a11847d0bf39b > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb > > Diff: https://reviews.apache.org/r/21428/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
