Thanks for the KIP. Looks good overall. However, I am wondering if the new exception should extend `KafkaException`? It seems, extending `ApiException` or maybe even `RetriableException` might be better?
About the name itself. I would prefer something simpler like `AbortedTransactionException`. Thoughts? -Matthias On 8/27/20 10:24 AM, Gokul Srinivas wrote: > Hello all, > > I would like to propose the following KIP to throw a new non-fatal > exception whilst aborting transactions with non-flushed data. This will > help users distinguish non-fatal errors and potentially retry the batch. > > *Issue *- https://issues.apache.org/jira/browse/KAFKA-10186 > <https://issues.apache.org/jira/browse/KAFKA-10186> > > *KIP *- > https://cwiki.apache.org/confluence/display/KAFKA/KIP-654:+Aborted+transaction+with+non-flushed+data+should+throw+a+non-fatal+exception > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-654:+Aborted+transaction+with+non-flushed+data+should+throw+a+non-fatal+exception> > > > Please let me know how best we can proceed with this. > > -Gokul > >
signature.asc
Description: OpenPGP digital signature
