I am going to propose that we take a vote on this KIP. Thank you Jason, Ron, Jun and Guozhang for the feedback and discussion.
On Fri, Oct 2, 2020 at 3:11 PM Jose Garcia Sancio <jsan...@confluent.io> wrote: > > Thank you Jun! > > Changes: > https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=158864763&selectedPageVersions=37&selectedPageVersions=36 > > > 41. Perhaps metadata.snapshot.min.records.size can just > > be metadata.snapshot.min.records? > > Sounds good to me. Done. > > > 42. It's probably fine to change maxBytes for Fetch in a separate PR. I > > brought this up since this KIP is changing the Fetch request. > > Okay. Minor nit. KIP-630 changed the Fetch response. We will bump the > Fetch request version because it is required but the KIP doesn't make > any changes to the fields in the Fetch request. > > -Jose -- -Jose
