[
https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010333#comment-14010333
]
Neha Narkhede commented on KAFKA-1316:
--------------------------------------
[~jkreps] Thanks for uploading the draft patch. Didn't do an indepth review
since this is WIP, but have a few high level comments -
1. It's probably worth adding a blocking API for poll since almost all consumer
coordination would want that
2. There is an issue with implementing heartbeats using the current
Sender/NetworkClient. If a user configures a higher fetch timeout, it will not
be able to heartbeat during that time. One option (that is pretty hacky) is to
create a separate connection between the consumer coordinator and the consumer.
Thoughts?
> Refactor Sender
> ---------------
>
> Key: KAFKA-1316
> URL: https://issues.apache.org/jira/browse/KAFKA-1316
> Project: Kafka
> Issue Type: Sub-task
> Components: producer
> Reporter: Jay Kreps
> Assignee: Jay Kreps
> Attachments: KAFKA-1316.patch
>
>
> Currently most of the logic of the producer I/O thread is in Sender.java.
> However we will need to do a fair number of similar things in the new
> consumer. Specifically:
> - Track in-flight requests
> - Fetch metadata
> - Manage connection lifecycle
> It may be possible to refactor some of this into a helper class that can be
> shared with the consumer. This will require some detailed thought.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
