> On May 27, 2014, 8:40 p.m., Neha Narkhede wrote: > > I get the following error while applying the patch- > > > > patching file bin/windows/kafka-run-class.bat > > Hunk #1 FAILED at 36. > > Hunk #2 FAILED at 121. > > 2 out of 2 hunks FAILED -- saving rejects to file > > bin/windows/kafka-run-class.bat.rej > > Sriharsha Chintalapani wrote: > whats your git version. I am using git 1.8.5.2 on OS X 10.9.2. Probably > issue with the older version of git but I'll test it again. > Thanks. > > Neha Narkhede wrote: > This is using patch. > patch -p1 -i kafka-1438.patch
I tested the new patch it applies cleanly against the trunk. MessageFormatter in ConsoleConsumer.scala should go into kafka.consumer is it ok to add this in its own file or should it go under existing file. please advise. There are few admin commands kafka.admin.TopicCommand, PreferredReplicaLeaderElectionCommand ReassignPartitionsCommand should they also be moved under tools. - Sriharsha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/#review44034 ----------------------------------------------------------- On May 28, 2014, 12:08 a.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21865/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 12:08 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1438 > https://issues.apache.org/jira/browse/KAFKA-1438 > > > Repository: kafka > > > Description > ------- > > KAFKA-1438. Migrate Kafka Client tools. > > > Diffs > ----- > > bin/kafka-console-consumer.sh e410dde271eea996416f7a67561e45b78f8e8a69 > bin/kafka-console-producer.sh cd8ce62fe51e3ad64908146f727f73fc6e35b35e > bin/kafka-consumer-perf-test.sh 4ed3ed9fb12edf00a82c06c4e59270a60df43ecd > bin/kafka-producer-perf-test.sh b4efc29d76ff8f53a310f812b9ed3de6875465b5 > bin/kafka-run-class.sh d2fc8c0e413769bb89ada99790b90ad616044f28 > bin/kafka-simple-consumer-perf-test.sh > 2d3e3d3be21065a4d446b9f8ed2e9d31c0685456 > bin/windows/kafka-console-consumer.bat > 94b20a4d1d2d043b4c4280d00b807d1d27089ac1 > bin/windows/kafka-console-producer.bat > b116e64cc4d8b19e0038f3dd1ff41bc5eb47abab > bin/windows/kafka-run-class.bat f4d2904a3320ae756ed4171f6e99566f1f0cf963 > core/src/main/scala/kafka/consumer/ConsoleConsumer.scala > 1a16c691683dda0c53f316e3c4797ea38e776574 > core/src/main/scala/kafka/producer/ConsoleProducer.scala > a2af988d99a94a20291d6a2dc9bec73197f1b756 > core/src/main/scala/kafka/server/OffsetManager.scala > 54176283e5f199d9db08e2181e7ddfbb9c801fab > perf/config/log4j.properties 542b7391550b2a8bb091a38d08583bea9b3111b6 > perf/src/main/scala/kafka/perf/ConsumerPerformance.scala > 4dde4687bada1202eaf54be2b06c2156e7726b23 > perf/src/main/scala/kafka/perf/PerfConfig.scala > a8fc6b9ec81c49c73c35172ddc5a67c6a96c799a > perf/src/main/scala/kafka/perf/ProducerPerformance.scala > 00fa90bb286900fb33a05f55e3c34c2cbb5620a1 > perf/src/main/scala/kafka/perf/SimpleConsumerPerformance.scala > c52ada0a30ae49c8d576703859b9d49348f62feb > > Diff: https://reviews.apache.org/r/21865/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
