-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22131/#review44588
-----------------------------------------------------------



core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala
<https://reviews.apache.org/r/22131/#comment79008>

    this should not be part of this ticket


- Joe Stein


On June 2, 2014, 2:32 p.m., Ivan Lyutov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22131/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 2:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1477
>     https://issues.apache.org/jira/browse/KAFKA-1477
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Reverted gradle version
> 
> 
> Added SSL for Kafka
> 
> Minor fixes, cleanup
> 
> Refactoring
> 
> Fixed tests compilation error.
> 
> 
> Diffs
> -----
> 
>   config/client.keystore PRE-CREATION 
>   config/client.public-key PRE-CREATION 
>   config/client.security.properties PRE-CREATION 
>   config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f 
>   config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 
>   config/server.keystore PRE-CREATION 
>   config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 
>   config/server.public-key PRE-CREATION 
>   config/server.security.properties PRE-CREATION 
>   core/src/main/scala/kafka/api/FetchRequest.scala 
> a8b73acd1a813284744359e8434cb52d22063c99 
>   core/src/main/scala/kafka/client/ClientUtils.scala 
> ba5fbdcd9e60f953575e529325caf4c41e22f22d 
>   core/src/main/scala/kafka/cluster/Broker.scala 
> 9407ed21fbbd57edeecd888edc32bea6a05d95b3 
>   core/src/main/scala/kafka/common/UnknownKeyStoreException.scala 
> PRE-CREATION 
>   core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 
> 1a16c691683dda0c53f316e3c4797ea38e776574 
>   core/src/main/scala/kafka/consumer/ConsumerConfig.scala 
> 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 
>   core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 
> b9e2bea7b442a19bcebd1b350d39541a8c9dd068 
>   core/src/main/scala/kafka/consumer/SimpleConsumer.scala 
> 0e64632210385ef63c2ad3445b55ac4f37a63df2 
>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 
> 65f518d47c7555c42c4bff39c211814831f4b8b6 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
> 8763968fbff697e4c5c98ab1274627c192a4d26a 
>   core/src/main/scala/kafka/network/BlockingChannel.scala 
> eb7bb14d94cb3648c06d4de36a3b34aacbde4556 
>   core/src/main/scala/kafka/network/SocketServer.scala 
> 4976d9c3a66bc965f5870a0736e21c7b32650bab 
>   core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SSLSocketChannel.scala 
> PRE-CREATION 
>   core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION 
>   core/src/main/scala/kafka/network/security/store/JKSInitializer.scala 
> PRE-CREATION 
>   core/src/main/scala/kafka/producer/ConsoleProducer.scala 
> a2af988d99a94a20291d6a2dc9bec73197f1b756 
>   core/src/main/scala/kafka/producer/ProducerConfig.scala 
> 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 
>   core/src/main/scala/kafka/producer/ProducerPool.scala 
> 43df70bb461dd3e385e6b20396adef3c4016a3fc 
>   core/src/main/scala/kafka/producer/SyncProducer.scala 
> 489f0077512d9a69be81649c490274964290fa40 
>   core/src/main/scala/kafka/producer/SyncProducerConfig.scala 
> 69b2d0c11bb1412ce76d566f285333c806be301a 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala 
> 3b15254f32252cf824d7a292889ac7662d73ada1 
>   core/src/main/scala/kafka/server/KafkaConfig.scala 
> ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
>   core/src/main/scala/kafka/server/KafkaHealthcheck.scala 
> 4acdd70fe9c1ee78d6510741006c2ece65450671 
>   core/src/main/scala/kafka/server/KafkaServer.scala 
> c22e51e0412843ec993721ad3230824c0aadd2ba 
>   core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 
> 19df757d75fdbb3ff0b434b6cb10338ff5cc32da 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala 
> fba652e3716a67b04431fc46790ad255201b639f 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 
> 91f072816418040a396a0cad26bc889f539dadd6 
>   core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 
> 747e07280cce72d621acbc771337b909a9b2487e 
>   core/src/main/scala/kafka/utils/ZkUtils.scala 
> fcbe269b6057b45793ea95f357890d5d6922e8d4 
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 
> fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 
>   core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 
> 35dc071b1056e775326981573c9618d8046e601d 
>   core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
> 62fb02cf02d3876b9804d756c4bf8514554cc836 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 
> 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb 
>   gradle/wrapper/gradle-wrapper.properties 
> 610282a699afc89a82203ef0e4e71ecc53761039 
> 
> Diff: https://reviews.apache.org/r/22131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Lyutov
> 
>

Reply via email to