Great! If this KIP is merged first, I will update the PR accordingly. Thanks, Dongjin
On Thu, Mar 18, 2021, 10:04 PM Randall Hauch <rha...@apache.org> wrote: > Thanks, Dongjin. > > We still have some time before this KIP might be approved, so I don’t want > to block any work on KIP-653. It’s fine for the KIP-653 PR to be merged > first. I’ll just have to update my PR when this KIP passes. > > On Thu, Mar 18, 2021 at 1:30 AM Dongjin Lee <dong...@apache.org> wrote: > > > Hi Randall, > > > > I am +1 for this proposal. Sure, changing this setting manually is so > > annoying. I think this proposal should be applied as soon as possible. > > > > However, I have a question: as you already know, the upgrade to > Log4j2[^1] > > was already passed but not merged yet. Which one would be the right > working > > path? Merge KIP-653 first and KIP-721 later, or merge KIP-721 first and > > apply the change into KIP-653? > > > > Thanks, > > Dongjin > > > > [^1]: > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-653%3A+Upgrade+log4j+to+log4j2 > > > > On Wed, Mar 17, 2021 at 6:31 AM Randall Hauch <rha...@apache.org> wrote: > > > > > Hello all, > > > > > > I'd like to propose KIP-721 to change Connect's Log4J configuration > that > > we > > > ship with AK. This KIP will enable by default Connect's valuable > > connector > > > log contexts, which was added as part of KIP-449 to include connector- > > and > > > task-specific information to every log message output by the connector, > > its > > > tasks, or the worker thread operating those components. > > > > > > The details are here: > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-721%3A+Enable+connector+log+contexts+in+Connect+Log4j+configuration > > > > > > The earlier KIP-449 (approved and implemented in AK 2.3.0) is here: > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-449%3A+Add+connector+contexts+to+Connect+worker+logs > > > > > > I look forward to your feedback! > > > > > > Best regards, > > > > > > Randall > > > > > > > > > -- > > *Dongjin Lee* > > > > *A hitchhiker in the mathematical world.* > > > > > > > > *github: <http://goog_969573159/>github.com/dongjinleekr > > <https://github.com/dongjinleekr>keybase: > https://keybase.io/dongjinleekr > > <https://keybase.io/dongjinleekr>linkedin: > kr.linkedin.com/in/dongjinleekr > > <https://kr.linkedin.com/in/dongjinleekr>speakerdeck: > > speakerdeck.com/dongjin > > <https://speakerdeck.com/dongjin>* > > >
