ableegoldman commented on pull request #345:
URL: https://github.com/apache/kafka-site/pull/345#issuecomment-813747095


   Hey, thanks for the fix but please revert the 28 folder. For one thing, we 
don't want the 2.8 docs to go live until 2.8 is actually released. For another, 
this is just a copy of the 2.7 docs, the 2.8 docs are generated and copied over 
from the kafka repo during the release process. Also this may mess with the 
release script/release process, but I'm not sure about that. 
   
   I just left a comment on the ticket but I'll reiterate it here: I would 
recommend to first submit a PR to fix this in the [kafka 
repo](https://github.com/apache/kafka) rather than in kafka-site, due to the 
ongoing 2.8 release. If the PR against the kafka repo can be merged in the next 
day or so, then it will get picked up in the 2.8 release and you won't even 
need to open a PR against the kafka-site repo at all. If we don't get it in 
before the 2.8 release, then you'll have to do the fix again in a PR against 
the kafka-site repo to fix it in the 28 folder that's generated during the 2.8 
release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to