-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21937/
-----------------------------------------------------------
(Updated June 7, 2014, 6:20 p.m.)
Review request for kafka.
Bugs: KAFKA-1316
https://issues.apache.org/jira/browse/KAFKA-1316
Repository: kafka
Description
-------
KAFKA-1316 Refactor a reusable NetworkClient interface out of Sender.
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/ClientRequest.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/ClientResponse.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/ConnectionState.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/InFlightRequests.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/KafkaClient.java PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/NodeConnectionState.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
d15562a968d9e4b08f26b8d30986881adfe29e31
clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java
f47a46159e9cf4161997470c6d4459cefcd0bd82
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
5ededccef7cb8e161822e9e5fc25e70a51dbe581
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java
5ee5455a84446966e1e3c54d37d5f541cd30c8a3
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
9b1f5653548ba90defdae43940a5554066770b0a
clients/src/main/java/org/apache/kafka/common/metrics/Measurable.java
7c2e33c3bf3b7acb6236553b9f6fd00881ffdf75
clients/src/main/java/org/apache/kafka/common/metrics/stats/Avg.java
c9963cb68ee227be7e6618a82b53714364f11531
clients/src/main/java/org/apache/kafka/common/metrics/stats/Count.java
efcd61bca983788c6132da5b23be847205f9421d
clients/src/main/java/org/apache/kafka/common/metrics/stats/Max.java
c492c3811cfab21bbd0dcb36904acdaf6a17b63f
clients/src/main/java/org/apache/kafka/common/metrics/stats/Min.java
bd0919cbec5bac9329e695480b57ad721eacfe51
clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java
8300978eaef59d19be70453b84d8b9bfb589f4eb
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java
4b481a54a4d532bc4ed50d30d986342eec6ef5e4
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java
0d4056fbc6ec98e1ef7f467c90340cb7c8711090
clients/src/main/java/org/apache/kafka/common/metrics/stats/Total.java
53dd3d5c2a0743111898d0483dc05f0cbb6306fc
clients/src/main/java/org/apache/kafka/common/network/ByteBufferSend.java
63504246320473a2eb5c300ffe73c433f7946a25
clients/src/main/java/org/apache/kafka/common/network/Selector.java
3e358985ed72a894a71d683acc7460695d6f2056
clients/src/main/java/org/apache/kafka/common/network/Send.java
d62dff9433f5098ae4662d98524efbaf9f57e62e
clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java
68b8827f3bdd64580e1b443fce5b8c63152dd94a
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java
428968cd38a7b12991f87868bf759926ff7e594e
clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java
6fa4a58f5f9792776a647e8f682d7faadc0d1556
clients/src/test/java/org/apache/kafka/clients/MockClient.java PRE-CREATION
clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java
PRE-CREATION
clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java
c4072ae90fb58101a67f83054fbe0b8349e71c2e
clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java
3ef692ca3e9fb83868a9da6f30c0705bb3d0aed2
clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java
e4e0a049740d317efa9a5a43e1006e4fc49d817e
clients/src/test/java/org/apache/kafka/common/utils/MockTime.java
cda8e644587aad9a8c9c96c222edc1ba27de1fb0
core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala
cd4ca2fa77763b090c6ad4ba4a5d46a6a8b76698
core/src/test/scala/unit/kafka/utils/TestUtils.scala
4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb
Diff: https://reviews.apache.org/r/21937/diff/
Testing
-------
Thanks,
Jay Kreps
