[
https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025718#comment-14025718
]
Jay Kreps commented on KAFKA-1316:
----------------------------------
Thanks for the feedback Neha:
1. Makes sense, we can definitely add that.
2. This is okay, though, right? The config for the two should be independent
even if some are similar, right?
3. Hmm, not so sure about this. That finds a target for the cluster metadata
request. The logic might be the same as for another type of metadata request
(e.g. to discover the co-ordinator) but it also might not. I would feel
concerned about exposing it unless we can come up with a very general
description of what it is doing...
> Refactor Sender
> ---------------
>
> Key: KAFKA-1316
> URL: https://issues.apache.org/jira/browse/KAFKA-1316
> Project: Kafka
> Issue Type: Sub-task
> Components: producer
> Reporter: Jay Kreps
> Assignee: Jay Kreps
> Attachments: KAFKA-1316.patch, KAFKA-1316_2014-06-03_11:15:38.patch,
> KAFKA-1316_2014-06-03_14:33:33.patch, KAFKA-1316_2014-06-07_11:20:38.patch
>
>
> Currently most of the logic of the producer I/O thread is in Sender.java.
> However we will need to do a fair number of similar things in the new
> consumer. Specifically:
> - Track in-flight requests
> - Fetch metadata
> - Manage connection lifecycle
> It may be possible to refactor some of this into a helper class that can be
> shared with the consumer. This will require some detailed thought.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
