----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22446/#review45314 -----------------------------------------------------------
Ship it! Minor comment. clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java <https://reviews.apache.org/r/22446/#comment80119> Do we really need super-fine granularity here? i.e., we wouldn't expect the buffer pool to be full for a long period - i.e., probably not as long as sampling intervals for graphing systems. So we can just measure the time for the original (full) await() no? - Joel Koshy On June 10, 2014, 11:15 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22446/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 11:15 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1488 > https://issues.apache.org/jira/browse/KAFKA-1488 > > > Repository: kafka > > > Description > ------- > > Add a new metric for measuring the ratio when the new producer is block for > space allocation. > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java > d1d6c4bba10384d0b38f057e74242e2ce44aafad > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java > 5ededccef7cb8e161822e9e5fc25e70a51dbe581 > clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java > f227b5c3ff365e30384eda51bd0c3f21ef14a8a4 > > Diff: https://reviews.apache.org/r/22446/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
