Thank you very much for all those that voted.

With four binding +1s and zero -1s, this vote passes.

Binding +1:
* Colin McCabe
* Matthias J. Sax
*  Sophie Blee-Goldman
* Jason Gustafson

Thanks everyone!

Sarwar

On Thu, 3 Jun 2021 at 00:16, Jason Gustafson <ja...@confluent.io.invalid>
wrote:

> +1 overall. There is one complication which I think we may have to address
> in the implementation. The KIP documents an override to `fillInStackTrace`.
> Is that necessary? The trace would indeed be useful in this case because
> the new exception will wrap the exception raised from the Deserializer.
> Unfortunately, `SerializationException` already has the same override, so
> we may have some difficulty getting around that. I think the solution is
> probably to remove the override from `SerializationException` since it also
> seems undesirable, but we can discuss when the patch is submitted.
>
> -Jason
>
> On Wed, Jun 2, 2021 at 2:34 PM Colin McCabe <cmcc...@apache.org> wrote:
>
> > +1 (binding)
> >
> > Thanks, Sarwar.
> >
> > best,
> > Colin
> >
> > On Wed, Jun 2, 2021, at 13:29, Sarwar Bhuiyan wrote:
> > > Thanks Colin, Matthias, and Jason on the discussion on this really old
> > KIP.
> > >
> > > As discussed, I'd like to start to vote on KIP-334:
> > >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87297793
> > >
> > > Thank you.
> > >
> > > Sarwar
> > >
> > > --
> > >
> > >
> > > [image: Confluent] <https://www.confluent.io/>
> > > Sarwar Bhuiyan
> > > Staff Customer Success Technical Architect
> > > +447949684437
> > > Follow us: [image: Blog]
> > > <
> >
> https://www.confluent.io/blog?utm_source=footer&utm_medium=email&utm_campaign=ch.email-signature_type.community_content.blog
> > >[image:
> > > Twitter] <https://twitter.com/ConfluentInc>[image: LinkedIn]
> > > <https://www.linkedin.com/company/confluent/>[image: Slack]
> > > <https://slackpass.io/confluentcommunity>[image: YouTube]
> > > <https://youtube.com/confluent>
> > > [image: Kafka Summit] <https://www.kafka-summit.org/>
> > >
> >
>
-- 


[image: Confluent] <https://www.confluent.io/>
Sarwar Bhuiyan
Staff Customer Success Technical Architect
+447949684437
Follow us: [image: Blog]
<https://www.confluent.io/blog?utm_source=footer&utm_medium=email&utm_campaign=ch.email-signature_type.community_content.blog>[image:
Twitter] <https://twitter.com/ConfluentInc>[image: LinkedIn]
<https://www.linkedin.com/company/confluent/>[image: Slack]
<https://slackpass.io/confluentcommunity>[image: YouTube]
<https://youtube.com/confluent>
[image: Kafka Summit] <https://www.kafka-summit.org/>

Reply via email to