On Tue, Jun 8, 2021, at 09:53, Jun Rao wrote: > Hi, Colin, > > Thanks for the update KIP. > > 2. BrokerRegistrationChangeRecord: > 2.1 Should the listeners field be named EndPoints to be consistent with > RegisterBrokerRecord?
Good point. I'll change this. > 2.2 Does the listeners field indicate the addition/removal or the full > current state of listeners? Full state. I will clarify this in the KIP. > 2.3. Does BrokerRegistrationChangeRecord need to also include IncarnationId? Broker ID and broker epoch are sufficient to identify a broker. Incarnation ID is used during broker registration to establish the broker epoch. The main advantage is it makes the broker registration RPC idempotent. But otherwise, we can continue identify a broker by ID and epoch like we always have. > 2.4 Since BrokerRegistrationChangeRecord has the fence field, do we still > need FenceBrokerRecord and UnfenceBrokerRecord? If we want to keep the > latter two, should they also include IncarnationId? The main reason I kept fence / unfence was for compatibility. If we want to break compatibility we could remove these. best, Colin > > Jun > > On Mon, Jun 7, 2021 at 7:59 AM Colin McCabe <[email protected]> wrote: > > > I added a tagged "Listeners" field to BrokerRegistrationChangeRecord, as > > we discussed earlier in this thread. This will be set only if the broker > > listeners have changed. > > > > best, > > Colin > > > > > > On Sat, Jun 5, 2021, at 09:03, Colin McCabe wrote: > > > Right, we are not supporting upgrade (as discussed earlier). However, > > > since 2.8 was an official release that had the earlier versions of the > > > records, I think it's good to bump the version when we make > > > incompatible changes. For documentation purposes, it's good to be able > > > to see the differences versus what we had in 2.8. It's also good to be > > > consistent here. What do you think? > > > > > > best, > > > Colin > > > > > > > > > On Thu, Jun 3, 2021, at 19:45, Ismael Juma wrote: > > > > Quick question: given that upgrades are not supported, do we actually > > want > > > > to introduce a new version for the RPCs? > > > > > > > > Ismael > > > > > > > > On Wed, Jun 2, 2021 at 11:02 AM Colin McCabe <[email protected]> > > wrote: > > > > > > > > > Hi all, > > > > > > > > > > I have posted a KIP about updating the KRaft metadata records for > > 3.0. > > > > > > > > > > Check it out at : https://cwiki.apache.org/confluence/x/34zOCg > > > > > > > > > > best, > > > > > Colin > > > > > > > > > > > > > > >
