Hi Luke, Thanks for the response, I have removed the PR link in the KIP (it was already in the JIRA issue) and I have also updated the code that generates the documentation for https://kafka.apache.org/documentation/#brokerconfigs_listeners (I also added an example of an IPv4+IPv6 listener configuration to the example list so its clear).
Regards On Thu, Nov 18, 2021 at 12:38 PM Luke Chen <show...@gmail.com> wrote: > Hi Matthew, > Thanks for the update. > The "listener" config description should also be updated: > https://kafka.apache.org/documentation/#brokerconfigs_listeners > > We stated: Listener names and port numbers must be unique. > It'll be wrong after this KIP. > > Also, the PR link should not be put onto the KIP. You can put in the JIRA > comment. > > Thank you. > Luke > > On Thu, Nov 18, 2021 at 7:34 PM Matthew de Detrich > <matthew.dedetr...@aiven.io.invalid> wrote: > > > Hi Luke, > > > > I have updated the KIP to make it clear that we are only talking about > > listeners and not advertised listeners. I have also updated/rebased the > PR > > at https://github.com/apache/kafka/pull/11478 to add upgrade notes about > > the suggested change. I am not sure if there is an additional place where > > you want me to document this change (I looked through the documentation > and > > couldn't find anything specific enough but I may have missed something). > > > > Let me know if anything else is needed. > > > > Regards > > > > On Thu, Nov 18, 2021 at 3:58 AM Luke Chen <show...@gmail.com> wrote: > > > > > Hi Matthew, > > > Thanks for the KIP. > > > > > > I have a question: > > > If I remembered correctly, the "advertised listeners" already support > > > duplicated ports, so your KIP should only focus on "listeners" > > > configuration, is that right? If so, could you please make it clear in > > KIP, > > > to mention that your change only apply to "listeners", not "advertised > > > listeners". > > > > > > Also, you should also mention in the KIP, that the doc for "listeners" > > will > > > also be updated. (I checked your PR, and found you missed that) > > > > > > Thank you. > > > Luke > > > > > > On Tue, Nov 16, 2021 at 10:24 PM Matthew de Detrich > > > <matthew.dedetr...@aiven.io.invalid> wrote: > > > > > > > Since no one has commented on either this thread or the original one > I > > > will > > > > summon a vote by the end of this week. > > > > > > > > Regards > > > > > > > > On Wed, Nov 10, 2021 at 5:28 PM Matthew de Detrich < > > > > matthew.dedetr...@aiven.io> wrote: > > > > > > > > > Hello everyone, > > > > > > > > > > I would like to start a discussion for KIP-797 which is about > > allowing > > > > > duplicate listeners on the same port in the specific case where one > > > host > > > > is > > > > > an IPv4 address and the other host is an IPv6 address. > > > > > > > > > > The proposal is here > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=195726330 > > > > > > > > > > Regards > > > > > -- > > > > > > > > > > Matthew de Detrich > > > > > > > > > > *Aiven Deutschland GmbH* > > > > > > > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > > > > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > > > > > *m:* +491603708037 > > > > > > > > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > > > > > > > > > > > > > > > > > -- > > > > > > > > Matthew de Detrich > > > > > > > > *Aiven Deutschland GmbH* > > > > > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > > > *m:* +491603708037 > > > > > > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > > > > > > > > > > > > > -- > > > > Matthew de Detrich > > > > *Aiven Deutschland GmbH* > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > *m:* +491603708037 > > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > > > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* matthew.dedetr...@aiven.io
