Hi, Jose, Thanks for the reply.
20. I see the differences now. The metrics in KafkaController use Yammer metric and follow the camel case naming. The metrics in Raft use the client side Metrics package and follow the dash notation. So the naming in the KIP sounds good to me. 21. Sounds good. Jun On Wed, May 18, 2022 at 2:11 PM José Armando García Sancio <jsan...@confluent.io.invalid> wrote: > Hi Jun, > > Jun wrote: > > 20. For the metric type and name, we use the camel names in some cases > and > > dashed lower names in some other cases. Should we make them consistent? > > For the metrics group `type=KafkaController`, I am using camel names > like `MetadataLastAppliedRecordOffset` because it matches the naming > strategy for the metrics already in that group. > > For the metrics group `type=broker-metadata-metrics`, I model the > naming scheme after the metrics in KIP-595 or the `raft-metrics` > group. I made the assumption that we wanted to start naming metrics > and groups using that scheme but maybe that is not correct. > > What do you think? > > > 21. Could you document the meaning of load-processing-time? > > I updated KIP-835 to include this information. Here is a summary: > > 1. > kafka.server:type=broker-metadata-metrics,name=load-processing-time-us-avg > Reports the average amount of time it took for the broker to process > all pending records when there are pending records in the cluster > metadata partition. The time unit for this metric is microseconds. > 2. > kafka.server:type=broker-metadata-metrics,name=load-processing-time-us-max > Reports the maximum amount of time it took for the broker to process > all pending records when there are pending records in the cluster > metadata partition. The time unit for this metric is microseconds. > 3. > kafka.server:type=broker-metadata-metrics,name=record-batch-size-byte-avg > Reports the average byte size of the record batches in the cluster > metadata partition. > 4. > kafka.server:type=broker-metadata-metrics,name=record-batch-size-byte-max > Reports the maximum byte size of the record batches in the cluster > metadata partition. > > -José >
