Thanks Sagar, The KIP looks good to me overall, I just have a minor comment on the motivation of it: "The Metrics registry is often used by concurrent threads" -> maybe we can be more clearer, by saying that "Concurrent thread may try to access the Metrics registry to create the same, instance-level metrics".
Otherwise, +1 from me. Since this is a very straight-forward KIP I think we can move on to the VOTE phase directly. Guozhang On Mon, May 23, 2022 at 5:46 AM Sagar <sagarmeansoc...@gmail.com> wrote: > Hi All, > > I would like to start a discussion thread on the following KIP: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-843%3A+Adding+metricOrElseCreate+method+to+Metrics > > PS: Note that I sent another email without the KIP number in the > subject line. Plz use this email for discussion and ignore the other one. > Sorry about the spamming. > > Thanks! > Sagar. > -- -- Guozhang
