divijvaidya commented on code in PR #420: URL: https://github.com/apache/kafka-site/pull/420#discussion_r924561314
########## css/fonts.css: ########## @@ -0,0 +1,82 @@ +/* cutive-mono-regular - latin-ext_latin */ +@font-face { + font-family: 'Cutive Mono'; + font-style: normal; + font-weight: 400; + src: local(''), Review Comment: https://stackoverflow.com/a/22835957 explains the rationale (for smiley but empty string follows same logic). Though this is only necessary for IE6-8 (very old browsers) to handle an edge case (different font with same name locally). I think I would remove it to reduce confusion while reading code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org