-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23566/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1430
https://issues.apache.org/jira/browse/KAFKA-1430
Repository: kafka
Description
-------
Rebased: Incorporated Jun's comments: 1. LogSegment.read() will also return
fetch info, even if the corresponding message set is empty; 2. Purgatory
checking satisfactory in checkAndMaybeWatch synchronously, and will only return
false if this thread successfully set the satisfactory bit to true; 3. Remove
the read lock on Partition's reading of the leaderOpt and epoch and making them
volatile instead since these two functions are just single read; 4. Other minor
fixes
Diffs
-----
core/src/main/scala/kafka/api/FetchResponse.scala
d117f10f724b09d6deef0df3a138d28fc91aa13a
core/src/main/scala/kafka/cluster/Partition.scala
f2ca8562f833f09d96ec4bd37efcacf69cd84b2e
core/src/main/scala/kafka/cluster/Replica.scala
5e659b4a5c0256431aecc200a6b914472da9ecf3
core/src/main/scala/kafka/consumer/SimpleConsumer.scala
0e64632210385ef63c2ad3445b55ac4f37a63df2
core/src/main/scala/kafka/log/FileMessageSet.scala
b2652ddbe2f857028d5980e29a008b2c614694a3
core/src/main/scala/kafka/log/Log.scala
b7bc5ffdecba7221b3d2e4bca2b0c703bc74fa12
core/src/main/scala/kafka/log/LogCleaner.scala
2faa196a4dc612bc634d5ff5f5f275d09073f13b
core/src/main/scala/kafka/log/LogSegment.scala
0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/server/AbstractFetcherThread.scala
3b15254f32252cf824d7a292889ac7662d73ada1
core/src/main/scala/kafka/server/DelayedFetch.scala PRE-CREATION
core/src/main/scala/kafka/server/DelayedProduce.scala PRE-CREATION
core/src/main/scala/kafka/server/FetchDataInfo.scala PRE-CREATION
core/src/main/scala/kafka/server/FetchRequestPurgatory.scala PRE-CREATION
core/src/main/scala/kafka/server/KafkaApis.scala
0b668f230c8556fdf08654ce522a11847d0bf39b
core/src/main/scala/kafka/server/LogOffsetMetadata.scala PRE-CREATION
core/src/main/scala/kafka/server/OffsetManager.scala
0e22897cd1c7e45c58a61c3c468883611b19116d
core/src/main/scala/kafka/server/ProducerRequestPurgatory.scala PRE-CREATION
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
75ae1e161769a020a102009df416009bd6710f4a
core/src/main/scala/kafka/server/ReplicaManager.scala
6a56a772c134dbf1e70c1bfe067223009bfdbac8
core/src/main/scala/kafka/server/RequestKey.scala PRE-CREATION
core/src/main/scala/kafka/server/RequestPurgatory.scala
3d0ff1e2dbd6a5c3587cffa283db70415af83a7b
core/src/test/scala/other/kafka/StressTestLog.scala
8fcd068b248688c40e73117dc119fa84cceb95b3
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala
9f04bd38be639cde3e7f402845dbe6ae92e87dc2
core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala
cec1caecc51507ae339ebf8f3b8a028b12a1a056
core/src/test/scala/unit/kafka/log/LogManagerTest.scala
d03d4c4ee5c28fb1fbab2af0b84003ec0fac36e3
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala
6b7603728ae5217565d68b92dd5349e7c6508f31
core/src/test/scala/unit/kafka/log/LogTest.scala
1da1393983d4b20330e7c7f374424edd1b26f2a3
core/src/test/scala/unit/kafka/message/BaseMessageSetTestCases.scala
6db245c956d2172cde916defdb0749081bf891fd
core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala
558a5d6765a2b2c2fd33dc75ed31873a133d12c9
core/src/test/scala/unit/kafka/server/ISRExpirationTest.scala
2cd3a3faf7be2bbc22a892eec78c6e4c05545e18
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala
0ec120a4a953114e88c575dd6b583874371a09e3
core/src/test/scala/unit/kafka/server/RequestPurgatoryTest.scala
4f61f8469df99e02d6ce7aad897d10e158cca8fd
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
b1c4ce9f66aa86c68f2e6988f67546fa63ed1f9b
Diff: https://reviews.apache.org/r/23566/diff/
Testing
-------
Thanks,
Guozhang Wang
