Re: [DISCUSS] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

[Chia-Ping Tsai]

On 2023/02/22 10:01:29 Alexandre Dupriez wrote:
> Hi Chia-Ping,
> 
> Thanks for your answer. Apologies I should have been clearer in the
> previous message. What I meant is, is there a plan to use the SPI more
> broadly inside the Kafka codebase?

no, there is no plan to reuse the SPI. 

> The question arises because the interface exposes a close() method
> which is never invoked by the ConsoleProducer. Hence, although we need
> to keep this method to maintain compatibility of the SPI with its
> current implementations

yep, you are right. the close() method is never executed by the 
ConsoleProducer. The ConsolerConsumer has similar issue 
(https://github.com/apache/kafka/pull/8978). I will fix it.

> we should perhaps clarify that this method is
> not used/deprecated, unless it is intended to be used in the future.

 I prefer to keep the close() since the new interface is similar to 
Deserializer. The close() method can be used to notify/release something when 
the console is going to be down.