-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23442/#review48139
-----------------------------------------------------------
Ran unit tests twice.
Saw the following failure twice.
kafka.api.IntegrationTestHarness > junit.framework.TestSuite$1.warning FAILED
junit.framework.AssertionFailedError: Class
kafka.api.IntegrationTestHarness has no public constructor TestCase(String
name) or TestCase()
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.TestSuite$1.runTest(TestSuite.java:93)
Saw the following failure once.
kafka.api.ConsumerTest > testSimpleConsumer FAILED
java.lang.AssertionError: expected:<4178> but was:<0>
at org.junit.Assert.fail(Assert.java:69)
at org.junit.Assert.failNotEquals(Assert.java:314)
at org.junit.Assert.assertEquals(Assert.java:94)
at org.junit.Assert.assertEquals(Assert.java:104)
at
kafka.api.ConsumerTest$$anonfun$testSimpleConsumer$1.apply$mcVI$sp(ConsumerTest.scala:31)
at
scala.collection.immutable.Range$ByOne$class.foreach$mVc$sp(Range.scala:282)
at
scala.collection.immutable.Range$$anon$2.foreach$mVc$sp(Range.scala:265)
at kafka.api.ConsumerTest.testSimpleConsumer(ConsumerTest.scala:27)
core/src/test/scala/integration/kafka/api/ConsumerTest.scala
<https://reviews.apache.org/r/23442/#comment84471>
License header.
- Jun Rao
On July 12, 2014, 8:06 p.m., Jay Kreps wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23442/
> -----------------------------------------------------------
>
> (Updated July 12, 2014, 8:06 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1330
> https://issues.apache.org/jira/browse/KAFKA-1330
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Draft version of the new consumer.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/KafkaClient.java
> 29658d4a15f112dc0af5ce517eaab93e6f00134b
> clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
> d8f9ce663ee24d2b0852c974136741280c39f8f8
> clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java
> 227f5646ee708af1b861c15237eda2140cfd4900
> clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
> 46efc0c8483acacf42b2984ac3f3b9e0a4566187
> clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java
> 436d8a479166eda29f2672b50fc99f288bbe3fa9
> clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
> fe93afa24fc20b03830f1d190a276041d15bd3b9
> clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java
> c3aad3b4d6b677f759583f309061193f2f109250
>
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java
> 4aa5b01d611631db72df47d50bbe30edb8c478db
>
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
> a016269512b6d6d6e0fd3fab997e9c8265024eb4
> clients/src/main/java/org/apache/kafka/common/Cluster.java
> c62707ab3aba26771fc4b993df28bf8c44f32309
> clients/src/main/java/org/apache/kafka/common/network/Selectable.java
> b68bbf00ab8eba6c5867d346c91188142593ca6e
> clients/src/main/java/org/apache/kafka/common/network/Selector.java
> 93f2f1c7b229205fc846b4e8bba527dd15355eb0
> clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
> 6fe7573973832615976defa37fe0dfbb8f911939
> clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java
> 044b03061802ee5e8ea4f1995fb0988e1a70e9a7
> clients/src/main/java/org/apache/kafka/common/protocol/types/Struct.java
> 8cecba50bf067713184208552af36469962cd628
> clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java
> 040e5b91005edb8f015afdfa76fd94e0bf3cb4ca
>
> clients/src/main/java/org/apache/kafka/common/requests/ConsumerMetadataRequest.java
> PRE-CREATION
>
> clients/src/main/java/org/apache/kafka/common/requests/ConsumerMetadataResponse.java
> PRE-CREATION
> clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
> PRE-CREATION
> clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
> PRE-CREATION
> clients/src/main/java/org/apache/kafka/common/utils/Utils.java
> 50af60198a3f20933d0e8cf89c3b95d89ee73f35
> clients/src/test/java/org/apache/kafka/clients/MockClient.java
> aae8d4a1e98279470587d397cc779a9baf6fee6c
> clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java
> 2f98192b064d1ce7c0779e901293edb8c3801915
>
> clients/src/test/java/org/apache/kafka/clients/producer/PartitionerTest.java
> f06e28ce21e80c1265258ad3ac7900b99e61493d
> clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java
> 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3
> clients/src/test/java/org/apache/kafka/test/MockSelector.java
> d61de529173314c044261ad9662bec735d67e97f
> core/src/test/scala/integration/kafka/api/ConsumerTest.scala PRE-CREATION
> core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala
> PRE-CREATION
> core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala
> 194dd70919a5f301d3131c56594e40a0ebb27311
> core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala
> 9f04bd38be639cde3e7f402845dbe6ae92e87dc2
> core/src/test/scala/unit/kafka/utils/TestUtils.scala
> 3faa884f8eb83c7c00baab416d0acfb488dc39c1
>
> Diff: https://reviews.apache.org/r/23442/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Kreps
>
>