Hi Chris, Thanks for taking a look at the KIP. I've removed the mention to the update mode. It was copied from somewhere else and I forgot to delete it.
Thanks, Mickael On Wed, Mar 8, 2023 at 7:26 PM Chris Egerton <chr...@aiven.io.invalid> wrote: > > Hi Mickael, > > Thanks for the KIP! LGTM. > > I find the rationales for the rejected alternatives convincing, and agree > with the deprecation plan and opt-in behavior for pre-4.0 releases. I also > appreciate the historical context provided in the motivation section about > why we don't already use a tag for the source cluster in MM2. > > One small note: the "add.source.alias.to.metrics" property has an update > mode listed in the KIP. Is this necessary? AFAIK that concept only applies > to broker configs. Shouldn't block the KIP either way since "Read only" > doesn't make any promises it can't keep, mostly asking for my own > edification. > > Cheers, > > Chris > > On Tue, Mar 7, 2023 at 10:15 AM Mickael Maison <mickael.mai...@gmail.com> > wrote: > > > Hi, > > > > I created a KIP to tag the MirrorSourceConnector metrics with the > > source cluster alias. Currently they only have the target cluster > > alias. > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-911%3A+Add+source+tag+to+MirrorSourceConnector+metrics > > > > Please take a look and let me know if you have any feedback. > > > > Thanks, > > Mickael > >
