Hi Ismael, I haven't worked on too many projects with conventional commits before, so forgive my ignorance. Could you share some of the advantages of this style of commit message over the existing style?
Cheers, Chris On Thu, Jun 8, 2023 at 12:34 PM Ismael Juma <[email protected]> wrote: > Hi Josep and Bruno, > > Thanks for the initial feedback, these are good questions. Let's give it a > few days for others to chime in. > > If there is general consensus that this is worth pursuing, my thinking is > that we'll need to find a volunteer to capture the specifics of how we > would use this approach in Kafka (including the points you raised), iterate > on it and then vote. > > How does that sound? > > Ismael > > > On Thu, Jun 8, 2023, 12:08 AM Josep Prat <[email protected]> > wrote: > > > Hi Ismael, > > > > Thanks for raising this topic Ismael, I like the idea, I think this would > > bring some more meaningful first-liners on the commits. I guess we could > > use the scope (what comes within parentheses) to indicate the module the > > commit refers to (if it's single module) > > However, I doubt if this can be used for the release notes as we rely on > > JIra for this purpose. > > > > Some questions that come to mind: > > - should `feat` only be used for KIPs? > > - should we use conventional commits to help cut the release (for > example, > > no `feat` commit in a patch version? > > - should we use the scope to indicate the module the commit touches? > > - should this be a convention for comitters to rewrite the message before > > squash-merging? Or will we enforce PR authors to follow this convention? > > > > Best, > > > > On Thu, Jun 8, 2023 at 8:13 AM Ismael Juma <[email protected]> wrote: > > > > > Hi, > > > > > > A number of open source projects have adopted the conventional commits > > > specification. What do people think about using this for Apache Kafka? > > > > > > https://www.conventionalcommits.org/en/v1.0.0/ > > > > > > Thanks, > > > Ismael > > > > > > > > > -- > > [image: Aiven] <https://www.aiven.io> > > > > *Josep Prat* > > Open Source Engineering Director, *Aiven* > > [email protected] | +491715557497 > > aiven.io <https://www.aiven.io> | < > https://www.facebook.com/aivencloud > > > > > <https://www.linkedin.com/company/aiven/> < > > https://twitter.com/aiven_io> > > *Aiven Deutschland GmbH* > > Alexanderufer 3-7, 10117 Berlin > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > Amtsgericht Charlottenburg, HRB 209739 B > > >
