Thanks Ivan for addressing the comments in the KIP, LGTM. +1
On Tue, 13 Jun 2023 at 18:31, Luke Chen <show...@gmail.com> wrote: > > Looks good. Thanks for the update. > > On Tue, Jun 13, 2023 at 8:08 PM Ivan Yurchenko <ivan0yurche...@gmail.com> > wrote: > > > Hi all! > > > > Thank you for your votes. > > > > Based on the proposal of Satish in the discussion thread, I modified the > > KIP a little bit by lowering the default value of > > `remote.log.metadata.custom.metadata.max.size` from 10 KiB to 128 bytes. I > > hope this doesn't change your vote, but feel free to raise your concerns. > > Thank you! > > > > Best, > > Ivan > > > > > > On Tue, 13 Jun 2023 at 11:09, Josep Prat <josep.p...@aiven.io.invalid> > > wrote: > > > > > Hi Ivan, > > > > > > Thank you very much for this KIP. +1 (binding) from me. > > > > > > Best, > > > > > > > > > On Tue, Jun 13, 2023 at 10:03 AM Luke Chen <show...@gmail.com> wrote: > > > > > > > +1 (binding) from me. > > > > > > > > Thanks. > > > > Luke > > > > > > > > On Tue, Jun 13, 2023 at 3:44 PM Matthew Benedict de Detrich > > > > <matthew.dedetr...@aiven.io.invalid> wrote: > > > > > > > > > > +1 (non binding). Thanks for KIP > > > > > > > > > > On Tue, Jun 13, 2023 at 3:38 AM Kamal Chandraprakash < > > > > > kamal.chandraprak...@gmail.com> wrote: > > > > > > > > > > > +1 (non-binding). Thanks for the KIP! > > > > > > > > > > > > On Mon, Jun 12, 2023, 21:23 Divij Vaidya <divijvaidy...@gmail.com> > > > > wrote: > > > > > > > > > > > > > I have reviewed the proposal and feel that it would be beneficial > > > to > > > > > > > implement. > > > > > > > > > > > > > > Vote +1 (non-binding) > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Divij Vaidya > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Jun 12, 2023 at 4:39 PM Ivan Yurchenko < > > > > ivan0yurche...@gmail.com > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Hello, > > > > > > > > > > > > > > > > Some interest in KIP-917 was expressed in the discussion thread > > > > [1]. > > > > > > > After > > > > > > > > addressing all the comments there, I'm putting it up to a vote. > > > > > > > > Thanks! > > > > > > > > > > > > > > > > Best, > > > > > > > > Ivan > > > > > > > > > > > > > > > > [1] > > > > https://lists.apache.org/thread/qpccqd3jy5rzvbt5ngtzo3dg9pzp722y > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Matthew de Detrich > > > > > > > > > > *Aiven Deutschland GmbH* > > > > > > > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > > > > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > > > > > *m:* +491603708037 > > > > > > > > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > > > > > > > > > > > > > -- > > > [image: Aiven] <https://www.aiven.io> > > > > > > *Josep Prat* > > > Open Source Engineering Director, *Aiven* > > > josep.p...@aiven.io | +491715557497 > > > aiven.io <https://www.aiven.io> | < > > https://www.facebook.com/aivencloud > > > > > > > <https://www.linkedin.com/company/aiven/> < > > > https://twitter.com/aiven_io> > > > *Aiven Deutschland GmbH* > > > Alexanderufer 3-7, 10117 Berlin > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > >
