[ 
https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071123#comment-14071123
 ] 

Guozhang Wang commented on KAFKA-1420:
--------------------------------------

Hello Jonathan,

Thanks for the comment. You can note that there are two createTopic functions, 
one in TestUtils and one in AdminUtils, and TestUtils.createTopic just calls 
AdminUtils.createTopics and then use the Seq[KafkaServer] to check if the topic 
metadata has been propagated to these servers.

For the AdminTest, where no Seq[KafkaServer] is used, we actually do not need 
the real running servers but just test some ZK-based admin utilities. In this 
case we can use AdminUtils.createTopic to replace the 
TestUtils.createOrUpdateTopicPartitionAssignmentPathInZK.

> Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with 
> TestUtils.createTopic in all unit tests
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-1420
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1420
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Guozhang Wang
>              Labels: newbie
>             Fix For: 0.8.2
>
>
> This is a follow-up JIRA from KAFKA-1389



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to