Hi Kamal, As we discussed offline, I will rename this KIP so that it only captures the aspect of renaming the previously added metrics to remove ambiguity. I will create another KIP for RemoteIndexCache metrics and other relevant tiered storage metrics.
On Tue, Jul 25, 2023 at 12:03 PM Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > Hi Abhijeet, > > Thanks for the KIP! > > We are changing the metric names from what was proposed in the KIP-405 and > adding new metrics for RemoteIndexCache. > In the KIP, it's not clear whether we are renaming the aggregate broker > level metrics for remote copy/fetch/failed-copy/failed-fetch. > > Are these metrics enough to monitor all the aspects of tiered storage? > > (eg) > 1. Metrics to see the Tier Lag Status by number of pending > segments/records. > 2. Similar to log-start-offset and log-end-offset metrics. Should we > expose local-log-start-offset and highest-offset-uploaded-to-remote-storage > as metric? > > Thanks, > Kamal > > On Mon, Jul 24, 2023 at 2:08 PM Abhijeet Kumar <abhijeet.cse....@gmail.com > > > wrote: > > > Hi All, > > > > I created KIP-930 for adding RemoteIndexCache stats and also to rename > some > > tiered storage metrics added as part of KIP-405 > > < > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-405%3A+Kafka+Tiered+Storage#KIP405:KafkaTieredStorage-NewMetrics > > > > > to remove ambiguity. > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-930%3A+Tiered+Storage+Metrics > > > > Feedback and suggestions are welcome. > > > > Regards, > > Abhijeet. > > > -- Abhijeet.