Thanks, Colin. +1 (binding) from me. I will note that Ziming mentioned in the DISCUSS thread that "There is a mistake that we use `--bootstrap-server` instead of `--bootstrap-server(s)`, so should we also change the new argument `--bootstrap-controller` (no s).". I agree that this is an unfortunate historical artifact. Furthermore, the config property is bootstrap.servers, which does not match the command line argument --bootstrap-server. I don't know what we should do here -- I am not sure that we should propagate it. We could continue the same mismatch and use --bootstrap-controller, but I feel like using --bootstrap-controllers makes more sense. Anyway, this is more an ergonomic issue than anything else. I am still +1 binding, but we should arrive at an explicit decision here.
Nits: s/boostrap-servers/bootstrap-servers/ s/DescribeClusterResquest/DescribeClusterRequest/ s/ControllerRegistrationRecord/RegisterControllerRecord/g Ron On Wed, Jul 26, 2023 at 10:06 AM David Arthur <david.art...@confluent.io.invalid> wrote: > > Thanks for driving this KIP, Colin! > > +1 binding > > -David > > On Wed, Jul 26, 2023 at 8:58 AM Divij Vaidya <divijvaidy...@gmail.com> > wrote: > > > +1 (binding) > > > > -- > > Divij Vaidya > > > > > > On Wed, Jul 26, 2023 at 2:56 PM ziming deng <dengziming1...@gmail.com> > > wrote: > > > > > > +1 (binding) from me. > > > > > > Thanks for the KIP! > > > > > > -- > > > Ziming > > > > > > > On Jul 26, 2023, at 20:18, Luke Chen <show...@gmail.com> wrote: > > > > > > > > +1 (binding) from me. > > > > > > > > Thanks for the KIP! > > > > > > > > Luke > > > > > > > > On Tue, Jul 25, 2023 at 1:24 AM Colin McCabe <cmcc...@apache.org> > > wrote: > > > > > > > >> Hi all, > > > >> > > > >> I'd like to start the vote for KIP-919: Allow AdminClient to Talk > > Directly > > > >> with the KRaft Controller Quorum and add Controller Registration. > > > >> > > > >> The KIP is here: https://cwiki.apache.org/confluence/x/Owo0Dw > > > >> > > > >> Thanks to everyone who reviewed the proposal. > > > >> > > > >> best, > > > >> Colin > > > >> > > > > > > > > -- > -David
