> On July 24, 2014, 1:21 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/utils/ZkUtils.scala, line 133 > > <https://reviews.apache.org/r/23702/diff/3/?file=639483#file639483line133> > > > > It will be good to refer to 1000 as a static variable inside > > KafkaConfig eg. KafkaConfig.MinimumBrokerSequenceId
need to change KafkaConfig to object to add a static variable instead passing it as a argument to ZkUtils.getBrokerIdSequenceId - Sriharsha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23702/#review48598 ----------------------------------------------------------- On July 25, 2014, 4:05 a.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23702/ > ----------------------------------------------------------- > > (Updated July 25, 2014, 4:05 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1070 > https://issues.apache.org/jira/browse/KAFKA-1070 > > > Repository: kafka > > > Description > ------- > > KAFKA-1070. Auto assign node id. > > > KAFKA-1070. Auto-assign node id. > > > KAFKA-1070. Auto-assign node id. > > > KAFKA-1070. Auto-assign node id. > > > Diffs > ----- > > core/src/main/scala/kafka/common/InconsistentBrokerIdException.scala > PRE-CREATION > core/src/main/scala/kafka/server/KafkaConfig.scala > 50b09edb73af1b45f88f919ac8c46ae056878c8e > core/src/main/scala/kafka/server/KafkaServer.scala > def1dc2a5818d45d9ee0881137ff989cec4eb9b1 > core/src/main/scala/kafka/utils/ZkUtils.scala > dcdc1ce2b02c996294e19cf480736106aaf29511 > core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala > PRE-CREATION > core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala > ab60e9b3a4d063c838bdc7f97b3ac7d2ede87072 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 4d01d25c73e1f986f58801296015efc491f9e45a > > Diff: https://reviews.apache.org/r/23702/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
