Hi Ashwin,

Thanks a lot for your review. 

> Thanks for the KIP and the PR (which helped me understand the change).
Do you think that something needs to be corrected in KIP to make it more 
understandable without PR? Do you have any advice?

> I could not understand one thing though - In 
> https://github.com/apache/kafka/pull/14203/, 
> why did you have to remove the code which sets sslEngineFactoryConfig in 
> instantiateSslEngineFactory?
If I understood the question correctly:
I've refactored this method a bit.  
SslFactory#instantiateSslEngineFactory was a private not-static method. I've 
separated the code that really creates new instance of the SslEngineFactory and 
place it into a public static method. There might be a better place for this 
public static method that creates the SslEngineFactory. I think we will discuss 
this at the final PR. Current PR is just a demo / prototype to play. 

Reply via email to