[ 
https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079439#comment-14079439
 ] 

Sriharsha Chintalapani commented on KAFKA-1507:
-----------------------------------------------

[~junrao] [~jkreps] Thanks for the details above. Based on the comments by Jay 
we should be dropping creation of topics from TopicMetaData request and add 
createTopicRequest to the api along with topic creation properties such 
partitions , replication etc. 
And in KafkaProducer.send if the metadatarequest comes out empty we should be 
making a call to createTopic .
In this case should we also have a boolean flag in KafkaProducer for 
createTopic . If both producer.createTopic and "auto.create.topics.enable" on 
broker set to true we will create a topic with user supplied config or using 
the defaults.
I think auto creation of topics config should be on the producer side rather 
than the broker having it on two places might be confusing. 
Please let me know what you think of the above approach. Thanks.

> Using GetOffsetShell against non-existent topic creates the topic 
> unintentionally
> ---------------------------------------------------------------------------------
>
>                 Key: KAFKA-1507
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1507
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8.1.1
>         Environment: centos
>            Reporter: Luke Forehand
>            Assignee: Sriharsha Chintalapani
>            Priority: Minor
>              Labels: newbie
>         Attachments: KAFKA-1507.patch, KAFKA-1507_2014-07-22_10:27:45.patch, 
> KAFKA-1507_2014-07-23_17:07:20.patch
>
>
> A typo in using GetOffsetShell command can cause a
> topic to be created which cannot be deleted (because deletion is still in
> progress)
> ./kafka-run-class.sh kafka.tools.GetOffsetShell --broker-list
> kafka10:9092,kafka11:9092,kafka12:9092,kafka13:9092 --topic typo --time 1
> ./kafka-topics.sh --zookeeper stormqa1/kafka-prod --describe --topic typo
> Topic:typo      PartitionCount:8        ReplicationFactor:1     Configs:
>          Topic: typo     Partition: 0    Leader: 10      Replicas: 10
>   Isr: 10
> ...



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to