Hi Raghu, Can you clarify why the currently proposed solution would have less compatibility issues? Also if you don't want to follow the AuthenticationContext alternative, can you add it to the rejected alternatives section.
Thanks, Mickael On Wed, Nov 8, 2023 at 1:42 AM Raghu B <raghu98...@gmail.com> wrote: > > Hi Mickael, > > Yes, it is a more elegant solution with minor code changes but considering > the backward compatibility and impact on existing custom > KafkaPrincipalBuilder implementations I thought the proposed solution is a > better option. > > Thanks, > Raghu > > On Thu, Nov 2, 2023 at 7:20 AM Mickael Maison <mickael.mai...@gmail.com> > wrote: > > > Hi Raghu, > > > > Thanks for the KIP. > > Have you considered retrieving these values using > > AuthenticationContext? For example SslAuthenticationContext could have > > a getter for SslPrincipalMapper. For kerberosShortNamer we could have > > a new subclass of SaslAuthenticationContext, for example > > GssapiAuthenticationContext. > > > > Thanks, > > Mickael > > > > On Mon, Oct 16, 2023 at 8:15 PM Manikumar <manikumar.re...@gmail.com> > > wrote: > > > > > > Hi Raghu, > > > > > > Thanks for the KIP. Proposed changes look good to me. > > > > > > Thanks, > > > Manikumar > > > > > > On Fri, Sep 22, 2023 at 11:44 PM Raghu B <raghu98...@gmail.com> wrote: > > > > > > > Hi everyone, > > > > > > > > I would like to start the discussion on the KIP-982 to Access > > > > SslPrincipalMapper and kerberosShortNamer in Custom > > KafkaPrincipalBuilder > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-982%3A+Access+SslPrincipalMapper+and+kerberosShortNamer+in+Custom+KafkaPrincipalBuilder > > > > > > > > Looking forward to your feedback! > > > > > > > > Thanks, > > > > Raghu > > > > > >
