jlprat commented on code in PR #571:
URL: https://github.com/apache/kafka-site/pull/571#discussion_r1422064925
##########
35/toc.html:
##########
@@ -152,7 +152,7 @@
<li><a href="#zk">6.9 ZooKeeper</a>
<ul>
<li><a href="#zkversion">Stable Version</a>
- <li><a href="#zk_depr">ZooKeeper Deprecation</a>
+ <li><a href="#zk_depr">ZooKeeper Deprecation</a>
Review Comment:
Really big nitpick, but the tabs are wrong now.
##########
35/documentation.html:
##########
@@ -30,7 +30,7 @@
<!--#include virtual="toc.html" -->
</div>
<div class="right">
- <!--#include virtual="../includes/_docs_banner.htm" -->
+ <!--//#include virtual="../includes/_docs_banner.htm" -->
Review Comment:
Shouldn't `//` be removed? We want the "_You're viewing documentation for an
older version of Kafka - check out our current documentation here._" message to
appear, right?
##########
35/ops.html:
##########
@@ -3443,20 +3443,23 @@ <h3 class="anchor-heading"><a id="zk"
class="anchor-link"></a><a href="#zk">6.9
<h4 class="anchor-heading"><a id="zkversion" class="anchor-link"></a><a
href="#zkversion">Stable version</a></h4>
The current stable branch is 3.5. Kafka is regularly updated to include the
latest release in the 3.5 series.
-
+
<h4 class="anchor-heading"><a id="zk_depr" class="anchor-link"></a><a
href="#zk_depr">ZooKeeper Deprecation</a></h4>
- <p>With the release of Apache Kafka 3.5, Zookeeper is now marked deprecated.
Removal of ZooKeeper is planned in the next major release of Apache Kafka
(version 4.0), which is scheduled to happen no sooner than April 2024. During
the deprecation phase, ZooKeeper is still supported for metadata management of
Kafka clusters, but it is not recommended for new deployments. There is a small
subset of features that remain to be implemented in KRaft, see <a
href="#kraft_missing">current missing features</a> for more information.</p>
+ <p>With the release of Apache Kafka 3.5, Zookeeper is now marked deprecated.
Removal of ZooKeeper is planned in the next major release of Apache Kafka
(version 4.0),
+ which is scheduled to happen no sooner than April 2024. During the
deprecation phase, ZooKeeper is still supported for metadata management of
Kafka clusters,
+ but it is not recommended for new deployments. There is a small subset of
features that remain to be implemented in KRaft
+ see <a href="#kraft_missing">current missing features</a> for more
information.</p>
<h5 class="anchor-heading"><a id="zk_depr_migration"
class="anchor-link"></a><a href="#zk_drep_migration">Migration</a></h5>
<p>Migration of an existing ZooKeeper based Kafka cluster to KRaft is
currently Preview and we expect it to be ready for production usage in version
3.6. Users are recommended to begin planning for migration to KRaft and also
begin testing to provide any feedback. Refer to <a
href="#kraft_zk_migration">ZooKeeper to KRaft Migration</a> for details on how
to perform a live migration from ZooKeeper to KRaft and current limitations.</p>
-
+
<h5 class="anchor-heading"><a id="zk_depr_3xsupport"
class="anchor-link"></a><a href="#zk_depr_3xsupport">3.x and ZooKeeper
Support</a></h5>
<p>The final 3.x minor release, that supports ZooKeeper mode, will receive
critical bug fixes and security fixes for 12 months after its release.</p>
-
+
<h5 class="anchor-heading"><a id="zk_depr_timeline"
class="anchor-link"></a><a href="#zk_depr_timeline">ZooKeeper and KRaft
timeline</a></h5>
<p>For details and updates on tentative timelines for ZooKeeper removal
and planned KRaft feature releases, refer to <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-833%3A+Mark+KRaft+as+Production+Ready";>KIP-833</a>.</p>
- <h4 class="anchor-heading"><a id="zkops" class="anchor-link"></a><a
href="#zkops">Operationalizing ZooKeeper</a></h4>
+<h4 class="anchor-heading"><a id="zkops" class="anchor-link"></a><a
href="#zkops">Operationalizing ZooKeeper</a></h4>
Review Comment:
Nitpick about misaligned indentation
##########
35/generated/mirror_source_config.html:
##########
@@ -440,6 +440,16 @@ <h4><a id="replication.policy.class"></a><a
id="mirror_source_replication.policy
</tbody></table>
</li>
<li>
+<h4><a id="replication.policy.internal.topic.separator.enabled"></a><a
id="mirror_source_replication.policy.internal.topic.separator.enabled"
href="#mirror_source_replication.policy.internal.topic.separator.enabled">replication.policy.internal.topic.separator.enabled</a></h4>
Review Comment:
Was this a forgotten documentation chunk that we forgot to add until now?
##########
35/generated/connect_config.html:
##########
@@ -364,7 +364,7 @@ <h4><a id="ssl.protocol"></a><a
id="connectconfigs_ssl.protocol" href="#connectc
<p>The SSL protocol used to generate the SSLContext. The default is 'TLSv1.3'
when running with Java 11 or newer, 'TLSv1.2' otherwise. This value should be
fine for most use cases. Allowed values in recent JVMs are 'TLSv1.2' and
'TLSv1.3'. 'TLS', 'TLSv1.1', 'SSL', 'SSLv2' and 'SSLv3' may be supported in
older JVMs, but their usage is discouraged due to known security
vulnerabilities. With the default value for this config and
'ssl.enabled.protocols', clients will downgrade to 'TLSv1.2' if the server does
not support 'TLSv1.3'. If this config is set to 'TLSv1.2', clients will not use
'TLSv1.3' even if it is one of the values in ssl.enabled.protocols and the
server only supports 'TLSv1.3'.</p>
<table><tbody>
<tr><th>Type:</th><td>string</td></tr>
-<tr><th>Default:</th><td>TLSv1.2</td></tr>
+<tr><th>Default:</th><td>TLSv1.3</td></tr>
Review Comment:
Was this a change we forgot to push on `3.5.0`? Because I doubt this was
changed between patches
##########
35/generated/mirror_heartbeat_config.html:
##########
@@ -330,6 +330,16 @@ <h4><a id="replication.policy.class"></a><a
id="mirror_heartbeat_replication.pol
</tbody></table>
</li>
<li>
+<h4><a id="replication.policy.internal.topic.separator.enabled"></a><a
id="mirror_heartbeat_replication.policy.internal.topic.separator.enabled"
href="#mirror_heartbeat_replication.policy.internal.topic.separator.enabled">replication.policy.internal.topic.separator.enabled</a></h4>
Review Comment:
Was this a forgotten documentation chunk that we forgot to add until now?
##########
35/javadoc/allclasses-index.html:
##########
@@ -655,7 +656,7 @@ <h1 title="All Classes and Interfaces" class="title">All
Classes and Interfaces<
<div class="col-first odd-row-color all-classes-table
all-classes-table-tab5"><a
href="org/apache/kafka/common/errors/CoordinatorLoadInProgressException.html"
title="class in
org.apache.kafka.common.errors">CoordinatorLoadInProgressException</a></div>
<div class="col-last odd-row-color all-classes-table all-classes-table-tab5">
<div class="block">In the context of the group coordinator, the broker returns
this error code for any coordinator request if
- it is still loading the group metadata (e.g.</div>
+ it is still loading the group metadata (e.g. after a leader change for that
group metadata topic partition).</div>
Review Comment:
Good catch, do we know why it got cut previously?
##########
35/generated/mirror_checkpoint_config.html:
##########
@@ -410,6 +410,16 @@ <h4><a id="replication.policy.class"></a><a
id="mirror_checkpoint_replication.po
</tbody></table>
</li>
<li>
+<h4><a id="replication.policy.internal.topic.separator.enabled"></a><a
id="mirror_checkpoint_replication.policy.internal.topic.separator.enabled"
href="#mirror_checkpoint_replication.policy.internal.topic.separator.enabled">replication.policy.internal.topic.separator.enabled</a></h4>
+<p>Whether to use replication.policy.separator to control the names of topics
used for checkpoints and offset syncs. By default, custom separators are used
in these topic names; however, if upgrading MirrorMaker 2 from older versions
that did not allow for these topic names to be customized, it may be necessary
to set this property to 'false' in order to continue using the same names for
those topics.</p>
+<table><tbody>
+<tr><th>Type:</th><td>boolean</td></tr>
+<tr><th>Default:</th><td>true</td></tr>
+<tr><th>Valid Values:</th><td></td></tr>
+<tr><th>Importance:</th><td>low</td></tr>
+</tbody></table>
+</li>
+<li>
Review Comment:
Was this a forgotten documentation chunk that we forgot to add until now?
##########
35/documentation.html:
##########
@@ -30,7 +30,7 @@
<!--#include virtual="toc.html" -->
</div>
<div class="right">
- <!--#include virtual="../includes/_docs_banner.htm" -->
+ <!--//#include virtual="../includes/_docs_banner.htm" -->
Review Comment:
If this is the case, it needs to be modified on all the other html doc pages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
