Hi Mickael, Thanks for the response. I've added the proposed default value for the refresh interval config. I've also added a new config to the KIP that will enable a TTL-based eviction policy for the in-memory LRO cache, as @huqedi suggested - also added a proposed default for this configuration. I did not get a chance/could not figure out a way to verify how much sense these default values make - so I'd be happy to be challenged on those. I've also skimmed through the MirrorMaker configs to check usages for configs that accept `-1` values - if my understanding is correct, `-1` is in the case of this metric would be intended to indicate that this metric should not be reported, since it would not be possible without the periodic LEO poll job. If my understanding is correct, I believe it makes sense to allow this - I've added a sentence about this to the KIP. Please take a look and let me know what you think,
Thanks! On Wed, 10 Jan 2024 at 15:31, Mickael Maison <mickael.mai...@gmail.com> wrote: > Hi Elxan, > > Thanks for the KIP, it looks like a useful addition. > > Can you add to the KIP the default value you propose for > replication.lag.metric.refresh.interval? In MirrorMaker most interval > configs can be set to -1 to disable them, will it be the case for this > new feature or will this setting only accept positive values? > I also wonder if replication-lag, or record-lag would be clearer names > instead of replication-offset-lag, WDYT? > > Thanks, > Mickael > > On Wed, Jan 3, 2024 at 6:15 PM Elxan Eminov <elxanemino...@gmail.com> > wrote: > > > > Hi all, > > Here is the vote thread: > > https://lists.apache.org/thread/ftlnolcrh858dry89sjg06mdcdj9mrqv > > > > Cheers! > > > > On Wed, 27 Dec 2023 at 11:23, Elxan Eminov <elxanemino...@gmail.com> > wrote: > > > > > Hi all, > > > I've updated the KIP with the details we discussed in this thread. > > > I'll call in a vote after the holidays if everything looks good. > > > Thanks! > > > > > > On Sat, 26 Aug 2023 at 15:49, Elxan Eminov <elxanemino...@gmail.com> > > > wrote: > > > > > >> Relatively minor change with a new metric for MM2 > > >> > > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-971%3A+Expose+replication-offset-lag+MirrorMaker2+metric > > >> > > > >
