Hi Andrew, Thanks for the hint! That sounds reasonable, do you think adding a conditional argument, something like "--time -1 --isolation -committed" and "--time -1 --isolation -uncommitted" would make sense to keep the consistency of getting the offset by time? or do you think having a special argument for this case is better?
On Tue, Feb 27, 2024 at 2:19 PM Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Hi Ahmed, > Thanks for the KIP. It looks like a useful addition. > > The use of negative timestamps, and in particular letting the user use > `--time -1` or the equivalent `--time latest` > is a bit peculiar in this tool already. The negative timestamps come from > org.apache.kafka.common.requests.ListOffsetsRequest, > but you’re not actually adding another value to that. As a result, I > really wouldn’t recommend using -6 for the new > flag. LSO is really a variant of -1 with read_committed isolation level. > > I think that perhaps it would be better to add `--last-stable` as an > alternative to `--time`. Then you’ll get the LSO with > cleaner syntax. > > Thanks, > Andrew > > > > On 27 Feb 2024, at 10:12, Ahmed Sobeh <ahmed.so...@aiven.io.INVALID> > wrote: > > > > Hi all, > > I would like to start a discussion on KIP-1021, which would enable > getting > > LSO in kafka-get-offsets.sh: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1021%3A+Allow+to+get+last+stable+offset+%28LSO%29+in+kafka-get-offsets.sh > > > > Best, > > Ahmed > > -- [image: Aiven] <https://www.aiven.io> *Ahmed Sobeh* Engineering Manager OSPO, *Aiven* ahmed.so...@aiven.io <i...@aiven.io> aiven.io <https://www.aiven.io> | <https://www.facebook.com/aivencloud> <https://www.linkedin.com/company/aiven/> <https://twitter.com/aiven_io> *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen Amtsgericht Charlottenburg, HRB 209739 B
