----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review50060 -----------------------------------------------------------
Ship it! Looks good to me, just a couple minor comments below. core/src/test/scala/unit/kafka/admin/AdminTest.scala <https://reviews.apache.org/r/24006/#comment87581> Could you move this function to TestUtils? core/src/test/scala/unit/kafka/admin/AdminTest.scala <https://reviews.apache.org/r/24006/#comment87584> we can probably just use sth. replicaSets.map(_.get(0)), otherwise we have to make sure that the leaders are correctly set. - Guozhang Wang On Aug. 2, 2014, 6:04 p.m., Jonathan Natkins wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24006/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2014, 6:04 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1420 > https://issues.apache.org/jira/browse/KAFKA-1420 > > > Repository: kafka > > > Description > ------- > > KAFKA-1420 Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK > with TestUtils.createTopic in unit tests > > > Diffs > ----- > > core/src/test/scala/unit/kafka/admin/AdminTest.scala > e28979827110dfbbb92fe5b152e7f1cc973de400 > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala > 29cc01bcef9cacd8dec1f5d662644fc6fe4994bc > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala > f44568cb25edf25db857415119018fd4c9922f61 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > c4e13c5240c8303853d08cc3b40088f8c7dae460 > > Diff: https://reviews.apache.org/r/24006/diff/ > > > Testing > ------- > > Automated > > > Thanks, > > Jonathan Natkins > >
