Thanks for clarifying Manikumar! +1 (binding) from me
Justine On Thu, Apr 4, 2024 at 3:19 AM Divij Vaidya <divijvaidy...@gmail.com> wrote: > Hi Manikumar > > I verified the following: > - all non-minor commits in the branch are captured in release notes > - signature on the artifact match the public signature of Manikumar > - basic topic creation & produce / consumer works with JDK8 + ARM + Kafka > 3.6.2 + Scala 2.12 + ZK + compression (zstd) > > Things look good to me. We don't need another RC for fixing docs. > > +1 (binding) from me. > > -- > Divij Vaidya > > > > On Thu, Apr 4, 2024 at 10:04 AM Manikumar <manikumar.re...@gmail.com> > wrote: > > > Hi Justine, > > > > Thanks for catching this. looks like we have missed updating > > `docs/documentation.html` in kafka repo during 3.5 and 3.6 release. > > > > I will make sure to use the correct version when updating docs for 3.6.2 > > release. > > I will also update 3.5 and 3.6 branches with the correct heading and also > > update the release wiki. > > > > >what was expected: "fullDotVersion": "3.6.2-SNAPSHOT" > > we will remove the "-SNAPSHOT" suffix while updating the website docs. we > > may need to automate this in the release script. > > > > > > [1] https://github.com/apache/kafka/blob/3.6/docs/documentation.html#L36 > > [2] https://github.com/apache/kafka/blob/3.5/docs/documentation.html#L36 > > > > > > Thanks, > > > > On Thu, Apr 4, 2024 at 3:50 AM Justine Olshan > <jols...@confluent.io.invalid > > > > > wrote: > > > > > Thanks for clarifying! > > > I took a look at the documentation.html file in there, and it said 3.4. > > Is > > > that expected? > > > > > > There are some files that request fullDot version and that seemed > closer > > to > > > what was expected: "fullDotVersion": "3.6.2-SNAPSHOT" > > > The upgrade.html file also looked ok. > > > > > > Thanks for running the release and answering my questions! > > > Justine > > > > > > On Wed, Apr 3, 2024 at 10:21 AM Manikumar <manikumar.re...@gmail.com> > > > wrote: > > > > > > > Hi Justine, > > > > > > > > Yes, it is intended. For bug fix releases website docs will be > updated > > > > during the final release process. > > > > We can verify the site-docs artifacts here: > > > > > > > > > > > > > > https://home.apache.org/~manikumar/kafka-3.6.2-rc2/kafka_2.12-3.6.2-site-docs.tgz > > > > These site-docs artifacts will be used to update website docs. > > > > > > > > > > > > Thanks, > > > > > > > > On Wed, Apr 3, 2024 at 10:30 PM Justine Olshan > > > > <jols...@confluent.io.invalid> > > > > wrote: > > > > > > > > > Hi Manikumar, > > > > > > > > > > I've verified the keys, scanned the artifacts, and other docs. > > > > > I built from source and ran with a ZK cluster (since I saw that we > > > > updated > > > > > ZK version in this release) > > > > > I ran a few tests on this cluster. > > > > > > > > > > I also ran the 2.12 binary. > > > > > > > > > > I noticed the docs link ( > > > https://kafka.apache.org/36/documentation.html) > > > > > mentions 3.6.1 as the latest. Is that intended? > > > > > I will give my final vote when we figure this out. > > > > > > > > > > Thanks, > > > > > Justine > > > > > > > > > > On Wed, Apr 3, 2024 at 7:25 AM Lianet M. <liane...@gmail.com> > wrote: > > > > > > > > > > > Hi Manikumar, I did the following checks: > > > > > > > > > > > > - downloaded and built from src > > > > > > - ran all unit test and integration test for clients > > > > > > - ran quickstart with Kraft mode > > > > > > - ran simple workloads with the console consumer/producer > > > > > > - checked all links > > > > > > > > > > > > All looks good to me with this. > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Apr 3, 2024, 2:19 a.m. Manikumar <maniku...@apache.org> > > > wrote: > > > > > > > > > > > > > Gentle reminder. Please download, test and vote for the > release. > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > On Fri, Mar 29, 2024 at 4:57 PM Manikumar < > maniku...@apache.org> > > > > > wrote: > > > > > > > > > > > > > > > Hi All, > > > > > > > > > > > > > > > > System test runs are green. There were 13 test failures in > the > > > > first > > > > > > run. > > > > > > > > All the failed tests passed in the second run. > > > > > > > > > > > > > > > > System test results: > > > > > > > > > > > https://gist.github.com/omkreddy/17d23d3eb36ef840011f2494d65bbd4f > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > On Thu, Mar 28, 2024 at 3:21 PM Manikumar < > > maniku...@apache.org> > > > > > > wrote: > > > > > > > > > > > > > > > >> Hello Kafka users, developers and client-developers, > > > > > > > >> > > > > > > > >> This is the second candidate we are considering for the > > release > > > of > > > > > > > Apache > > > > > > > >> Kafka 3.6.2. > > > > > > > >> > > > > > > > >> This is a bugfix release with several fixes, including > > > dependency > > > > > > > >> version bumps for CVEs. > > > > > > > >> > > > > > > > >> Release notes for the 3.6.2 release: > > > > > > > >> > > > > > > > https://home.apache.org/~manikumar/kafka-3.6.2-rc2/RELEASE_NOTES.html > > > > > > > >> > > > > > > > >> *** Please download, test and vote by by Wednesday, April > 3rd > > > > > > > >> > > > > > > > >> Kafka's KEYS file containing PGP keys we use to sign the > > > release: > > > > > > > >> https://kafka.apache.org/KEYS > > > > > > > >> > > > > > > > >> * Release artifacts to be voted upon (source and binary): > > > > > > > >> https://home.apache.org/~manikumar/kafka-3.6.2-rc2/ > > > > > > > >> > > > > > > > >> > > > > > > > >> * Maven artifacts to be voted upon: > > > > > > > >> > > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/kafka/ > > > > > > > >> > > > > > > > >> * Javadoc: > > > > > > > >> https://home.apache.org/~manikumar/kafka-3.6.2-rc2/javadoc/ > > > > > > > >> > > > > > > > >> * Tag to be voted upon (off 3.6 branch) is the 3.6.2 tag: > > > > > > > >> https://github.com/apache/kafka/releases/tag/3.6.2-rc2 > > > > > > > >> > > > > > > > >> * Documentation: > > > > > > > >> https://kafka.apache.org/36/documentation.html > > > > > > > >> > > > > > > > >> * Protocol: > > > > > > > >> https://kafka.apache.org/36/protocol.html > > > > > > > >> > > > > > > > >> * Successful Jenkins builds for the 3.6 branch: > > > > > > > >> Unit/integration tests: > > > > > > > >> > https://ci-builds.apache.org/job/Kafka/job/kafka/job/3.6/167/ > > > > (test > > > > > > > >> failures passed in local runs) > > > > > > > >> System tests: I will update system test results soon. > > > > > > > >> > > > > > > > >> > > > > > > > >> Thanks, > > > > > > > >> Manikumar > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
