To clarify, when you build with Java 21 and pass "--release 8" (like we do), it's the same as building with Java 8. That's why compiling with a specific version doesn't actually help (unlike running with multiple versions).
Ismael On Mon, May 27, 2024, 11:36 PM Luke Chen <show...@gmail.com> wrote: > > I did not see build failure that happens in 11 and 17 but not in 8 or 21, > and also it can save more CI resources and make our CI be thinner. > Same here. I've never seen build passed in jdk 21 but failed in 11 or 17. > But even if it happened, it is rare. I think we are just making a trade-off > to make CI more reliable and faster. > > Thanks. > Luke > > On Tue, May 28, 2024 at 2:22 PM Chia-Ping Tsai <chia7...@apache.org> > wrote: > > > Dear all, > > > > I do love Harris's patch as no one love slow CI I believe. For another, I > > file https://issues.apache.org/jira/browse/KAFKA-16847 just now to > revise > > our readme about JDK. I'd like to raise more discussion here. > > > > > Note that compilation with Java 11/17 doesn't add any value over > > compiling > > > with Java 21 with the appropriate --release config (which we set). So, > > this > > > part of the build process is wasteful. > > > > I did not see build failure that happens in 11 and 17 but not in 8 or 21, > > and also it can save more CI resources and make our CI be thinner. Hence, > > I'm +1 to drop 11 and 17 totally. > > > > Best, > > Chia-Ping > > > > > > On 2024/05/28 04:40:48 Ismael Juma wrote: > > > Hi Greg, > > > > > > Thanks for making this change. > > > > > > Note that compilation with Java 11/17 doesn't add any value over > > compiling > > > with Java 21 with the appropriate --release config (which we set). So, > > this > > > part of the build process is wasteful. Running the tests does add some > > > value (and hence why we originally had it), but the return on > investment > > is > > > not good enough given our CI issues (and hence why the change is good). > > > > > > Ismael > > > > > > On Mon, May 27, 2024, 8:20 PM Greg Harris <greg.har...@aiven.io.invalid > > > > > wrote: > > > > > > > Hello Apache Kafka Developers, > > > > > > > > In order to better utilize scarce CI resources shared with other > Apache > > > > projects, the Kafka project will no longer be running full test > suites > > for > > > > the JDK 11 & 17 components of PR builds. > > > > > > > > *Action requested: If you have an active pull request, please merge > or > > > > rebase the latest trunk into your branch* before continuing > > development as > > > > normal. You may wait to push the resulting branch until you make > > another > > > > commit, or push the result immediately. > > > > > > > > What to expect with this change: > > > > * Trunk (and release branch) builds will not be affected. > > > > * JDK 8 and 21 builds will not be affected. > > > > * Compilation will not be affected. > > > > * Static analysis (spotbugs, checkstyle, etc) will not be affected. > > > > * Overall build execution time should be similar or slightly better > > than > > > > before. > > > > * You can expect fewer tests to be run on your PRs (~60000 instead of > > > > ~120000). > > > > * Test flakiness should be similar or slightly better than before. > > > > > > > > And as a reminder, build failures (red indicators in CloudBees) are > > always > > > > blockers for merging. Starting now, the 11 and 17 builds should > always > > pass > > > > (green indicators in CloudBees) before merging, as failed tests > (yellow > > > > indicators in CloudBees) should no longer be present. > > > > > > > > Thanks everyone, > > > > Greg Harris > > > > > > > > > >
