----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/#review50656 -----------------------------------------------------------
core/src/main/scala/kafka/server/KafkaApis.scala <https://reviews.apache.org/r/24620/#comment88510> It is worth adding this error code to the new producer protocol (org.apache.kafka.common.protocol.Errors). If we do this, the producer will get a specific error code notifying it that the request was dropped due to an invalid topic. Currently, in this patch, the client would receive an unknown error code core/src/test/scala/unit/kafka/producer/ProducerTest.scala <https://reviews.apache.org/r/24620/#comment88509> I suspect this test will be more productive if written using the new producer. That way, we could verify the received error code more specifically to be InvalidTopicException. - Neha Narkhede On Aug. 12, 2014, 11:42 p.m., Jonathan Natkins wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24620/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2014, 11:42 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1580 > https://issues.apache.org/jira/browse/KAFKA-1580 > > > Repository: kafka > > > Description > ------- > > KAFKA-1580 Reject producer requests to internal topics > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaApis.scala > bb94673c8f3079a4053e0a7d58689e69775cdf8b > core/src/test/scala/unit/kafka/producer/ProducerTest.scala > dd71d81041e1baa3e3ebdbc38f60f247ebd65948 > > Diff: https://reviews.apache.org/r/24620/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Natkins > >
