----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review50675 -----------------------------------------------------------
Thanks for the patch. core/src/main/scala/kafka/log/Log.scala <https://reviews.apache.org/r/24704/#comment88535> As summarized in the ticket description we should have per-topic overrides as well. If the topic's config has an explicit override to use a specific compression type then we should use that. Or would you like to do this in a follow-up patch? core/src/main/scala/kafka/log/Log.scala <https://reviews.apache.org/r/24704/#comment88537> Rather than make this a var can this be set correctly up front? i.e., I think in analyzeAndValidateMessageSet core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala <https://reviews.apache.org/r/24704/#comment88539> Can you also add a test to LogTest - i.e., that the feature actually works? - Joel Koshy On Aug. 14, 2014, 5:01 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24704/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 5:01 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1499 > https://issues.apache.org/jira/browse/KAFKA-1499 > > > Repository: kafka > > > Description > ------- > > Support given for Broker-side compression. Introduced new server property > default.compression.type and topic override property compression.type > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 0ddf97bd30311b6039e19abade41d2fbbad2f59b > core/src/main/scala/kafka/log/LogConfig.scala > 5746ad4767589594f904aa085131dd95e56d72bb > core/src/main/scala/kafka/server/KafkaConfig.scala > 1a45f8716ccc0398cf9395d91d66199d16882aae > core/src/main/scala/kafka/server/KafkaServer.scala > 28711182aaa70eaa623de858bc063cb2613b2a4d > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > 2377abe4933e065d037828a214c3a87e1773a8ef > > Diff: https://reviews.apache.org/r/24704/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
