Hi Chia-Ping, Thanks for pointing that out. I originally wrote the full version to show the equivalent semantic example, but you're absolutely right—it can be simplified by omitting `.withGroupMembershipOperation(GroupMembershipOperation.DEFAULT)` since it's the default value.
This actually gave me an idea to include the shorter version for clarity in the explanation. I will update it accordingly. Sincerely, TengYao Chia-Ping Tsai <chia7...@gmail.com> 於 2024年10月7日 週一 下午1:13寫道： > +1 (binding) > > nit: in the "Migration Plan" > > ``` > consumer.close(CloseOption.timeout(Duration.ofSeconds(30)) > .withGroupMembershipOperation(GroupMembershipOperation.DEFAULT)); > ``` > > The sample above can likely be simplified, right? > > ``` > consumer.close(CloseOption.timeout(Duration.ofSeconds(30))); > ``` > > Best, > Chia-Ping > > TengYao Chi <kiting...@gmail.com> 於 2024年10月7日 週一 上午10:23寫道： > > > Hi everyone, > > > > Based on our discussion > > <https://lists.apache.org/thread/023mo7lk1vfvljjoovwbzwmw9wvf5t6m> > > regarding KIP-1092 <https://cwiki.apache.org/confluence/x/JQstEw>, I > > believe this KIP is now ready for a vote. > > > > Sincerely, > > TengYao > > >
