Thanks Greg, Chris and Ashwin For the individual queries,
1. The example is incorrect and both should be treated as exact versions. Thanks for pointing that out. 2. I can see a converter/transformation having a version property but it's probably not likely. That said I don't see why we should not use plugin.version to make this more specific and avoid encountering this in the first place. Will make the appropriate changes to the KIP to include these two points. Thanks Snehashis On Tue, Oct 8, 2024 at 10:33 AM Ashwin <apan...@confluent.io.invalid> wrote: > Hi Snehasis, > > Thanks for the KIP - +1 (non-binding) > > I just had a question regarding the sample config in > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=235834793#KIP891:RunningmultipleversionsofConnectorplugins-Configuration > > > "connector.version": "3.8" > > "transforms.flatten-old.version": "3.8.0" > > How will the feature be implemented so that first config treated as an > exact version requirement, while the second one is a > "use-only-if-you-have-it" version ? > > Thanks, > Ashwin > > > On Tue, Oct 8, 2024 at 12:19 AM Chris Egerton <fearthecel...@gmail.com> > wrote: > > > Hi Snehashis, > > > > Thanks for the KIP. I'm +1 (binding) but have one more non-blocking > thought > > I wanted to share. > > > > On the off chance that an existing plugin is designed to accept a > "version" > > property, could we either 1) keep passing that property to plugins > instead > > of stripping it, or 2) rename our new property to something like > > "plugin.version"? > > > > Feel free to close the vote (if/when it gets a third binding+1) without > > addressing this if you believe the tradeoffs with the existing design are > > superior. > > > > Cheers, > > > > Chris > > > > On Mon, Oct 7, 2024, 11:22 Greg Harris <greg.har...@aiven.io.invalid> > > wrote: > > > > > Hey Snehashis, > > > > > > Thanks for the KIP! +1 (binding) > > > > > > Greg > > > > > > On Fri, Oct 4, 2024 at 10:14 PM Snehashis <snehashisp1...@gmail.com> > > > wrote: > > > > > > > Hi everyone > > > > > > > > I would like to call a vote for KIP-891. Please take a moment to > review > > > the > > > > proposal and submit your vote. Special thanks to Greg who helped to > > > expand > > > > this to make it much more broadly useful, and everyone else who > > > > participated in both discussion threads. > > > > > > > > KIP > > > > KIP-891: Running multiple versions of Connector plugins - Apache > Kafka > > - > > > > Apache Software Foundation > > > > < > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-891%3A+Running+multiple+versions+of+Connector+plugins > > > > > > > > > > > > > Thanks > > > > Snehashis > > > > > > > > > >
