Hi David. Thanks for the review. Yes, we will disallow the negative duration. Updated the KIP.
Thanks, On Fri, Nov 15, 2024 at 9:33 PM David Arthur <mum...@gmail.com> wrote: > Mani, thanks for this KIP. It looks quite useful. > > I had one small question -- what happens if someone gives a negative > duration? From what I can tell this is allowed in the ISO8601 spec. Should > we explicitly disallow these, or perhaps auto-convert them to positive > durations (via Duration#abs)? > > -David A > > On Fri, Nov 15, 2024 at 9:06 AM Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > > > Hi Manikumar, > > > > Thanks for the KIP! Duration based offset reset is a useful addition when > > remote storage is enabled. > > > > +1 (binding) > > > > Thanks, > > Kamal > > > > On Thu, Nov 14, 2024 at 7:51 PM Apoorv Mittal <apoorvmitta...@gmail.com> > > wrote: > > > > > Hi Manikumar, > > > Thanks for the KIP. It will be a valuable addition. > > > > > > +1 (non-binding) > > > > > > Regards, > > > Apoorv Mittal > > > > > > > > > On Thu, Nov 14, 2024 at 2:11 PM Hector Geraldino (BLOOMBERG/ 919 3RD > A) < > > > hgerald...@bloomberg.net> wrote: > > > > > > > Thanks for the KIP > > > > > > > > +1 (non-binding) > > > > > > > > From: dev@kafka.apache.org At: 11/14/24 09:00:52 UTC-5:00To: > > > > dev@kafka.apache.org > > > > Subject: Re: [VOTE] KIP-1106: Add duration based offset reset option > > for > > > > consumer clients > > > > > > > > Hi Manikumar, > > > > Thanks for the KIP. > > > > > > > > +1 (non-binding) > > > > > > > > Thanks, > > > > Andrew > > > > ________________________________________ > > > > From: Manikumar <manikumar.re...@gmail.com> > > > > Sent: 14 November 2024 13:30 > > > > To: dev <dev@kafka.apache.org> > > > > Subject: [VOTE] KIP-1106: Add duration based offset reset option for > > > > consumer > > > > clients > > > > > > > > Hi All, > > > > > > > > I would like to start start vote on KIP-1106: > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1106%3A+Add+duration+based > > > > +offset+reset+option+for+consumer+clients > > > > > > > > This KIP proposes to add an additional auto offset reset strategy for > > > > consumer clients. > > > > > > > > Regards, > > > > Manikumar > > > > > > > > > > > > > > > > > > > > -- > David Arthur >
