> On Aug. 28, 2014, 5:36 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, line 20 > > <https://reviews.apache.org/r/25136/diff/1/?file=670850#file670850line20> > > > > Is this necessary? ReassignedPartitionContext seems not used anywhere.
No. I suppose it got autoimported in intellij > On Aug. 28, 2014, 5:36 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala, lines 35-48 > > <https://reviews.apache.org/r/25136/diff/1/?file=670857#file670857line35> > > > > Is this intentional? Nope. I ran autoformat in intellij and my settings for that did this. Changing it now > On Aug. 28, 2014, 5:36 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala, line 144 > > <https://reviews.apache.org/r/25136/diff/1/?file=670857#file670857line144> > > > > Is this intentional? Not all. Again autoformat in intellij > On Aug. 28, 2014, 5:36 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala, line 132 > > <https://reviews.apache.org/r/25136/diff/1/?file=670858#file670858line132> > > > > For resulted maps that are used in the constructor parameters, as long > > as the constructor parameter will not change we can use mapValues. Changing it now. - Mayuresh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/#review51793 ----------------------------------------------------------- On Aug. 28, 2014, 6:12 p.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25136/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2014, 6:12 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1610 > https://issues.apache.org/jira/browse/KAFKA-1610 > > > Repository: kafka > > > Description > ------- > > Patch for replacing mapValues by map wherever necessary so that local > modifications to collections are not lost > > > Diffs > ----- > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala > 691d69a49a240f38883d2025afaec26fd61281b5 > core/src/main/scala/kafka/controller/KafkaController.scala > 8ab4a1b8072c9dd187a9a6e94138b725d1f1b153 > core/src/main/scala/kafka/log/LogManager.scala > 4d2924d04bc4bd62413edb0ee2d4aaf3c0052867 > core/src/main/scala/kafka/server/DelayedFetch.scala > e0f14e25af03e6d4344386dcabc1457ee784d345 > core/src/main/scala/kafka/server/DelayedProduce.scala > 9481508fc2d6140b36829840c337e557f3d090da > core/src/main/scala/kafka/server/KafkaApis.scala > c584b559416b3ee4bcbec5966be4891e0a03eefb > core/src/main/scala/kafka/server/KafkaServer.scala > 28711182aaa70eaa623de858bc063cb2613b2a4d > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala > af4783646803e58714770c21f8c3352370f26854 > core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala > c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e > > Diff: https://reviews.apache.org/r/25136/diff/ > > > Testing > ------- > > Ran the unit tests and everything passed and the build succeeeded > > > Thanks, > > Mayuresh Gharat > >
