I wanted to give an update on this effort. Both the initial PR above and a
few follow-ups have been merged since my original email.

We now have a simple label-based workflow in GitHub for our PRs.

1) When a PR is opened by a community member it is automatically given the
"triage" label
2) If no review or comment is given after 7 days on a "triage" PR, a new
label "needs-attention" is added
3) If a review is given, both labels will be removed in a nightly batched
cron job

The rationale behind this is that committers often have very little trouble
getting reviews. After all, we know each other and can often directly tag
an appropriate reviewer. This is not always the case for community members.
By automating these two labels, it gives committers quick access to
incoming community PRs (1) as well as PRs which have had no activity in
some time (2).

Committers may consider bookmarking these two links:

1) https://github.com/apache/kafka/pulls?q=is%3Aopen+is%3Apr+label%3Atriage
2)
https://github.com/apache/kafka/pulls?q=is%3Aopen+is%3Apr+label%3Aneeds-attention

By the way, if we feel like 7 days is too aggressive for the follow-up
"needs-attention" label, I'm open to suggestions for a different time frame.

Thanks!
David A

P.S., if you are a committer and you notice your PRs are getting a "triage"
label, it is because your membership in the ASF GitHub org is not public. I
have included instructions for changing this here
https://github.com/apache/kafka/blob/trunk/.github/workflows/README.md#pr-triage

On Wed, Nov 20, 2024 at 8:25 PM Matthias J. Sax <mj...@apache.org> wrote:

> Nice!
>
> On 11/20/24 10:09 AM, David Arthur wrote:
> > Hey folks,
> >
> > I have raised a PR that adds the notion of "triage" to our Pull Requests.
> >
> > https://github.com/apache/kafka/pull/17881/files
> >
> > The tldr is that new PRs from non-committers will get labeled with
> "triage"
> > and then with "needs-attention" after 7 days. The purpose is to raise
> > visibility of non-committer PRs.
> >
> >
> > ---
> >
> >  From the PR:
> >
> > This patch adds a simple label based workflow for PRs. PRs opened by
> > non-committers will have a triage label automatically added. This allows
> > committers to see which PRs need to be triaged. After 7 days, a
> > needs-attention label will be added. This serves as a reminder to
> > committers and allows them to see which PRs have languished.
> >
> > For now, the triage label will need to be manually removed by a
> committer.
> > In the future, we could try to automate this by removing the label after
> a
> > PR has been reviewed, assigned, or commented on.
> >
> >
>


-- 
David Arthur

Reply via email to