[ 
https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117638#comment-14117638
 ] 

nicu marasoiu edited comment on KAFKA-1282 at 9/1/14 8:25 PM:
--------------------------------------------------------------

I am sorry, Yes, that was the intent! I will write unit tests from now on to 
avoid such slips.

Moreover, the removeEldestEntry will return false all the time, because it 
keeps the responsability of mutating the map for itself, as part of calling the 
close method. 

Attached the patch.

But I cannot compile test anymore!
:core:classes
:core:compileTestJava UP-TO-DATE
:core:compileTestScala
:core:processTestResources
:core:testClasses
> Building > :core:test
It remains stuck in this phase (and it happens with any scala version, it 
happens after disabling avast antivirus, and it happens after fully recloning 
the git in an antivirus excluded folder, it happens when i checkout an old 
revision - seems to be something with gradle or scala changed in my local 
environment, although i did not make any explicit update or upgrade; i use 
Intellij).


was (Author: nmarasoi):
I am sorry, Yes, that was the intent! I will write unit tests from now on to 
avoid such slips.

Moreover, the removeEldestEntry will return false all the time, because it 
keeps the responsability of mutating the map for itself, as part of calling the 
close method. 

Attached the patch.

Since the last rebase, I cannot compile test anymore!
Building 0% > :test_core_2_10_1 > :kafka:core:test
It remains stuck in this phase (and it happens with any scala version, it 
happens after disabling avast antivirus, and it happens after fully recloning 
the git in an antivirus excluded folder, it happens when i checkout an old 
revision - seems to be something with gradle or scala changed in my local 
environment, although i did not make any explicit update or upgrade; i use 
Intellij).

> Disconnect idle socket connection in Selector
> ---------------------------------------------
>
>                 Key: KAFKA-1282
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1282
>             Project: Kafka
>          Issue Type: Bug
>          Components: producer 
>    Affects Versions: 0.8.2
>            Reporter: Jun Rao
>            Assignee: Neha Narkhede
>              Labels: newbie++
>             Fix For: 0.9.0
>
>         Attachments: 
> KAFKA-1282_Disconnect_idle_socket_connection_in_Selector.patch, 
> idleDisconnect.patch
>
>
> To reduce # socket connections, it would be useful for the new producer to 
> close socket connections that are idle. We can introduce a new producer 
> config for the idle time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to