----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/#review52276 -----------------------------------------------------------
A few more minor comments below. core/src/main/scala/kafka/server/RequestPurgatory.scala <https://reviews.apache.org/r/25155/#comment91042> How about we name this watched()? core/src/main/scala/kafka/server/RequestPurgatory.scala <https://reviews.apache.org/r/25155/#comment91043> How about we name this delayed()? core/src/main/scala/kafka/server/RequestPurgatory.scala <https://reviews.apache.org/r/25155/#comment91044> I'd prefer that we make delayed a private val and expose a method delayed() that returns the size of the delayed queue. This is also consistent with the Watchers class. core/src/main/scala/kafka/server/RequestPurgatory.scala <https://reviews.apache.org/r/25155/#comment91045> Begin purging watch lists core/src/main/scala/kafka/server/RequestPurgatory.scala <https://reviews.apache.org/r/25155/#comment91046> Begin purging delayed queue. core/src/test/scala/unit/kafka/server/RequestPurgatoryTest.scala <https://reviews.apache.org/r/25155/#comment91047> If we do the renaming in RequestPurgatory, we don't have to rename those methods here. - Jun Rao On Sept. 3, 2014, 7:52 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25155/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2014, 7:52 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1616 > https://issues.apache.org/jira/browse/KAFKA-1616 > > > Repository: kafka > > > Description > ------- > > Incorporated Jun's comments round four > > > Diffs > ----- > > core/src/main/scala/kafka/server/RequestPurgatory.scala > ce06d2c381348deef8559374869fcaed923da1d1 > core/src/test/scala/unit/kafka/server/RequestPurgatoryTest.scala > 168712de241125982d556c188c76514fceb93779 > > Diff: https://reviews.apache.org/r/25155/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
