Hi all, Thanks for all the votes. We already have 4 binding votes. I am planning to close the vote in 24 hours.
Best, David On Sun, Mar 16, 2025 at 12:31 PM Luke Chen <show...@gmail.com> wrote: > Hi David, > > The system tests link works for me now. Thanks. > The failed tests are the same as RC3, so it looks good to me. > > Thanks. > Luke > > On Sat, Mar 15, 2025 at 10:48 PM 黃竣陽 <s7133...@gmail.com> wrote: > > > Hello David, > > > > I've completed the following tests on my local machine: > > > > - Built from source using JDK 21 & JDK 17 (Zulu, Amazon, Eclipse) in > > docker container > > - Executed all unit and integration tests > > - Ran the quickstart successfully > > - test console consumer and producer > > - Tested dynamic voter with 4.0 and 3.9 controllers > > - Tested 4.0 controller with a 3.9 broker > > > > +1 (non-binding) > > > > Best Regards > > Jiunn-Yang > > > > > David Jacot <david.ja...@gmail.com> 於 2025年3月15日 下午5:53 寫道： > > > > > > Hi Luke, > > > > > > The link works for me. Have you tried from a different browser or a > > > different device? > > > > > > Best, > > > David > > > > > > Le sam. 15 mars 2025 à 10:42, Luke Chen <show...@gmail.com> a écrit : > > > > > >> Hi David, > > >> > > >> For the system tests: > > >>> System tests: > > >> > > >> > > > https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2025-03-13--001.6a14e68a-4791-44eb-a6be-24ce25bc1678--1741882266--apache--4.0--8f765a1886/report.html > > >> > > >> This page is blank in my browser. Is that only me seeing this? > > >> > > >> Thanks. > > >> Luke > > >> > > >> On Sat, Mar 15, 2025 at 4:09 PM Luke Chen <show...@gmail.com> wrote: > > >> > > >>> Hi David, > > >>> > > >>> From @Jusine > > >>>> I was able to run the tests I wanted and I found when I use the > > upgrade > > >>> --release version flag, we are still saying we are upgrading > > >> kraft.version > > >>> to 1 even though we do not. I don't think this is necessarily a > > blocker, > > >>> but wanted to call it out. > > >>> > > >>> I've opened KAFKA-18992 > > >>> <https://issues.apache.org/jira/browse/KAFKA-18992> to track it. And > > +1 > > >>> for not a blocker. > > >>> > > >>> I've done: > > >>> > > >>> - Browsed the javadoc and protocol and documentation > > >>> - Ran the quickstart > > >>> - Verified that KIP-853 feature > > >>> - Verified tiered storage feature > > >>> > > >>> I also opened KAFKA-18993 > > >>> <https://issues.apache.org/jira/browse/KAFKA-18993> to improve the > > >>> document, but again, not a blocker. > > >>> > > >>> +1 (binding) > > >>> > > >>> Thanks for running the release! > > >>> Luke > > >>> > > >>> On Sat, Mar 15, 2025 at 12:21 PM TengYao Chi <kiting...@gmail.com> > > >> wrote: > > >>> > > >>>> Hi David, > > >>>> > > >>>> I have done the following tests: > > >>>> > > >>>> - Built from 4.0.0-rc4 with JDK21-zulu/JDK21-amzn and ran all unit > and > > >>>> integration tests in a container > > >>>> - a few tests failed at the first attempt, but failed tests > passed > > >>>> after retried > > >>>> - Ran all system tests > > >>>> - The network_degrade_test and replica_verification_test failed, > > but > > >>>> given the conclusion from the RC3 mail thread, I think this is > > >> acceptable. > > >>>> - Ran the KRaft quickstart using kafka_2.13-4.0.0.tgz > > >>>> - Built JVM and native images with rc4 archive and tested JVM and > > native > > >>>> containers by following the Multiple Nodes example from Docker Hub > > >>>> - Test dynamic quorum using kafka_2.13-4.0.0.tgz and > > >> kafka_2.13-3.9.0.tgz > > >>>> with the following matrix: > > >>>> - 4.0 controller / 4.0 broker > > >>>> - 4.0 controller as leader / 4.0 controller and 3.9 controller as > > >>>> voter > > >>>> / 4.0 broker and 3.9 broker as follower > > >>>> - 3.9 controller as leader / 4.0 controller and 3.9 controller as > > >>>> voter > > >>>> / 4.0 broker and 3.9 broker as follower > > >>>> - also create some topics > > >>>> > > >>>> > > >>>> +1 (non-binding) > > >>>> > > >>>> Best Regards, > > >>>> TengYao > > >>>> > > >>>> Justine Olshan <jols...@confluent.io.invalid> 於 2025年3月15日 週六 > > 上午2:38寫道： > > >>>> > > >>>>> Hello again folks, > > >>>>> > > >>>>> I chatted with Jose offline about this issue and he explained we > need > > >> to > > >>>>> remove the --standalone flag to get kraft.version=0. I filed a > ticket > > >>>> for > > >>>>> this here: https://issues.apache.org/jira/browse/KAFKA-18987 > > >>>>> > > >>>>> I was able to run the tests I wanted and I found when I use the > > >> upgrade > > >>>>> --release version flag, we are still saying we are upgrading > > >>>> kraft.version > > >>>>> to 1 even though we do not. I don't think this is necessarily a > > >> blocker, > > >>>>> but wanted to call it out. > > >>>>> > > >>>>> bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade > > >>>>> --release-version 4.0 group.version was upgraded to 1. > kraft.version > > >> was > > >>>>> upgraded to 1. metadata.version was upgraded to 25. > > >> transaction.version > > >>>> was > > >>>>> upgraded to 2. bin/kafka-features.sh --bootstrap-server > > localhost:9092 > > >>>>> describe Feature: eligible.leader.replicas.version > > >> SupportedMinVersion: > > >>>> 0 > > >>>>> SupportedMaxVersion: 1 FinalizedVersionLevel: 0 Epoch: 189 Feature: > > >>>>> group.version SupportedMinVersion: 0 SupportedMaxVersion: 1 > > >>>>> FinalizedVersionLevel: 1 Epoch: 189 Feature: kraft.version > > >>>>> SupportedMinVersion: 0 SupportedMaxVersion: 1 > FinalizedVersionLevel: > > 0 > > >>>>> Epoch: 189 Feature: metadata.version SupportedMinVersion: 3.3-IV3 > > >>>>> SupportedMaxVersion: 4.0-IV3 FinalizedVersionLevel: 4.0-IV3 Epoch: > > 189 > > >>>>> Feature: transaction.version SupportedMinVersion: 0 > > >>>> SupportedMaxVersion: 2 > > >>>>> FinalizedVersionLevel: 2 Epoch: 189 I ran the remaining > validations I > > >>>> had > > >>>>> (running transactions bench, verifying expected behavior). In > > >> addition, > > >>>> I > > >>>>> also verified the signatures, browsed the docs, looked at the tests > > >> and > > >>>>> release artifacts. +1 (binding) from me with a strong > recommendation > > >> to > > >>>>> update some of the docs around KIP-853. Thanks, > > >>>>> Justine > > >>>>> > > >>>>> On Fri, Mar 14, 2025 at 9:46 AM Justine Olshan < > jols...@confluent.io > > > > > >>>>> wrote: > > >>>>> > > >>>>>> Hi David, > > >>>>>> > > >>>>>> Thanks for this next release candidate. > > >>>>>> > > >>>>>> Maybe I'm missing something, but I was trying to test out some of > > >> the > > >>>>>> changes that Jose provided, by configuring a static quorum > > >>>>>> (kraft.version=0) and I seem to be unable to do so. > > >>>>>> I set controller.quorum.voters=1@localhost:9093 as per how it > > >> looked > > >>>> in > > >>>>>> 3.9 (with no controller.quorum.bootstrap.servers, but no matter > what > > >>>> I do > > >>>>>> it says "Cannot set kraft.version to 0 if KIP-853 configuration is > > >>>>>> present. Try removing the --feature flag for kraft.version." > > >>>>>> > > >>>>>> Can someone help me out here? The documentation says: > > >>>>>>> The static versus dynamic nature of the quorum is determined at > > >> the > > >>>>>> time of formatting. Specifically, the quorum will be formatted as > > >>>> dynamic > > >>>>>> if controller.quorum.voters is *not* present, and if the software > > >>>> version > > >>>>>> is Apache Kafka 3.9 or newer. If you have followed the > instructions > > >>>>> earlier > > >>>>>> in this document, you will get a dynamic quorum. > > >>>>>> > > >>>>>> But this seems incorrect. I'm hoping I'm just misunderstanding the > > >>>>>> documentation and not that there is another issue. > > >>>>>> > > >>>>>> Thanks, > > >>>>>> > > >>>>>> Justine > > >>>>>> > > >>>>>> On Fri, Mar 14, 2025 at 9:22 AM Bill Bejeck <bbej...@apache.org> > > >>>> wrote: > > >>>>>> > > >>>>>>> Hi David, > > >>>>>>> > > >>>>>>> I verified the latest RC with the following steps: > > >>>>>>> > > >>>>>>> - Verified the signatures > > >>>>>>> - Built from source > > >>>>>>> - Ran the unit tests (same single failure from before, but > > >>>> otherwise > > >>>>>>> all > > >>>>>>> good) > > >>>>>>> - Executed the quickstart against the built source code. > > >>>>>>> - Ran the streams quickstart. > > >>>>>>> - Tested the apache/kafka and apache/kafka-native docker images > > >>>> with > > >>>>>>> the > > >>>>>>> quickstart > > >>>>>>> - Spot checked the javadoc and documentation. > > >>>>>>> > > >>>>>>> +1(binding) > > >>>>>>> > > >>>>>>> Thanks, > > >>>>>>> Bill > > >>>>>>> > > >>>>>>> On Fri, Mar 14, 2025 at 10:36 AM Lianet M. <liane...@gmail.com> > > >>>> wrote: > > >>>>>>> > > >>>>>>>> Hi David, I verified the new RC with the following steps: > > >>>>>>>> > > >>>>>>>> - Checked system tests run: there were 2 new failures in connect > > >>>> that > > >>>>> we > > >>>>>>>> didn't have in the previous RC (test_broker_compatibility and > > >>>>>>>> test_pause_state_persistent). I ran them locally and they both > > >> pass > > >>>>> (so > > >>>>>>>> based on this and the error msg seems like just flakiness) > > >>>>>>>> - Build from src with java 17, followed the quickstart and > played > > >>>> with > > >>>>>>>> consume/produce & topic management with the command line tools > > >>>>>>>> - Run client examples from the examples module (java 17) > > >>>>>>>> - Tested consuming in groups with both classic and new consumer > > >>>>> protocol > > >>>>>>>> - Tested the consumer group online migration & the command line > > >> new > > >>>>>>> tools > > >>>>>>>> to visualize/track the live migration > > >>>>>>>> - Build clients with java 11 , run unit and integration tests. > > >>>>>>>> - Run client examples from the examples module (java 11) > > >>>>>>>> > > >>>>>>>> +1 (non-binding) > > >>>>>>>> > > >>>>>>>> Thanks! > > >>>>>>>> Lianet > > >>>>>>>> > > >>>>>>>> On Fri, Mar 14, 2025 at 9:28 AM David Arthur <mum...@gmail.com> > > >>>>> wrote: > > >>>>>>>> > > >>>>>>>>> David, thanks for running this behemoth of a release. > > >>>>>>>>> > > >>>>>>>>> With the help of my coworker Mahsa Seifikar, we have verified > > >> the > > >>>>>>>> following > > >>>>>>>>> upgrade scenario: > > >>>>>>>>> > > >>>>>>>>> * Provision a ZK based Kafka cluster on 3.5 and create some > > >>>> topics > > >>>>>>>>> * Upgrade to 3.9 > > >>>>>>>>> * Migrate to KRaft > > >>>>>>>>> * Upgrade to 4.0 > > >>>>>>>>> > > >>>>>>>>> We found a few docs issues which have since been fixed. One > > >> minor > > >>>>> 3.9 > > >>>>>>>> docs > > >>>>>>>>> issue is still pending, but that's not a blocker. > > >>>>>>>>> > > >>>>>>>>> I also ran through the quickstart. > > >>>>>>>>> > > >>>>>>>>> +1 binding > > >>>>>>>>> > > >>>>>>>>> -David A > > >>>>>>>>> > > >>>>>>>>> On Fri, Mar 14, 2025 at 7:57 AM Federico Valeri < > > >>>>> fedeval...@gmail.com > > >>>>>>>> > > >>>>>>>>> wrote: > > >>>>>>>>> > > >>>>>>>>>> Hi David, I've tested the RC4 and this is what I've done: > > >>>>>>>>>> > > >>>>>>>>>> - Used the binaries to create a cluster and run clients from > > >>>>>>> exampled > > >>>>>>>>>> module > > >>>>>>>>>> - Tested the upgrade issue we found in KAFKA-18979 > > >>>>>>>>>> - Tested the dynamic quorum feature (both scale up and down) > > >>>>>>>>>> - Tested group.protocol=consumer with a simple Java app > > >>>>>>>>>> - Browsed the documentation and javadoc > > >>>>>>>>>> - Tested the Docker images > > >>>>>>>>>> > > >>>>>>>>>> +1 non binding > > >>>>>>>>>> > > >>>>>>>>>> Thanks for running the release. > > >>>>>>>>>> > > >>>>>>>>>> Cheers > > >>>>>>>>>> Fede > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> On Fri, Mar 14, 2025 at 11:11 AM David Jacot < > > >> da...@apache.org > > >>>>> > > >>>>>>> wrote: > > >>>>>>>>>>> > > >>>>>>>>>>> Hello Kafka users, developers and client-developers, > > >>>>>>>>>>> > > >>>>>>>>>>> This is the fourth candidate for release of Apache Kafka > > >>>> 4.0.0. > > >>>>>>>>>>> > > >>>>>>>>>>> - This is the first release without Apache Zookeeper > > >>>>>>>>>>> - The Next Generation of the Consumer Rebalance Protocol is > > >>>>>>> Generally > > >>>>>>>>>> Available > > >>>>>>>>>>> - The Transactions Server-Side Defense (Phase 2) is > > >> Generally > > >>>>>>>> Available > > >>>>>>>>>>> - Queues for Kafka is in Early Access > > >>>>>>>>>>> - Kafka uses log4j2 > > >>>>>>>>>>> - Drop broker and tools support for Java 11 > > >>>>>>>>>>> - Remove old client protocol API versions > > >>>>>>>>>>> > > >>>>>>>>>>> Release notes for the 4.0.0 release: > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>> > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >> > > > https://dist.apache.org/repos/dist/dev/kafka/4.0.0-rc4/RELEASE_NOTES.html > > >>>>>>>>>>> > > >>>>>>>>>>> *** Please download, test and vote by Monday, March 17, 9am > > >>>> PT. > > >>>>>>>>>>> > > >>>>>>>>>>> Kafka's KEYS file containing PGP keys we use to sign the > > >>>>> release: > > >>>>>>>>>>> https://kafka.apache.org/KEYS > > >>>>>>>>>>> > > >>>>>>>>>>> * Release artifacts to be voted upon (source and binary): > > >>>>>>>>>>> https://dist.apache.org/repos/dist/dev/kafka/4.0.0-rc4/ > > >>>>>>>>>>> > > >>>>>>>>>>> * Docker release artifacts to be voted upon: > > >>>>>>>>>>> apache/kafka:4.0.0-rc4 > > >>>>>>>>>>> apache/kafka-native:4.0.0-rc4 > > >>>>>>>>>>> > > >>>>>>>>>>> * Maven artifacts to be voted upon: > > >>>>>>>>>>> > > >>>>>>>> > > >>>>> > > >> > https://repository.apache.org/content/groups/staging/org/apache/kafka/ > > >>>>>>>>>>> > > >>>>>>>>>>> * Javadoc: > > >>>>>>>>>>> > > >>>> https://dist.apache.org/repos/dist/dev/kafka/4.0.0-rc4/javadoc/ > > >>>>>>>>>>> > > >>>>>>>>>>> * Tag to be voted upon (off 4.0 branch) is the 4.0.0 tag: > > >>>>>>>>>>> https://github.com/apache/kafka/releases/tag/4.0.0-rc4 > > >>>>>>>>>>> > > >>>>>>>>>>> * Documentation: > > >>>>>>>>>>> https://kafka.apache.org/40/documentation.html > > >>>>>>>>>>> > > >>>>>>>>>>> * Protocol: > > >>>>>>>>>>> https://kafka.apache.org/40/protocol.html > > >>>>>>>>>>> > > >>>>>>>>>>> * Successful CI builds for the 4.0 branch: > > >>>>>>>>>>> Unit/integration tests: > > >>>>>>>>>> https://github.com/apache/kafka/actions/runs/13846870683 > > >>>>>>>>>>> System tests: > > >>>>>>>>>> > > >>>>>>>>> > > >>>>>>>> > > >>>>>>> > > >>>>> > > >>>> > > >> > > > https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2025-03-13--001.6a14e68a-4791-44eb-a6be-24ce25bc1678--1741882266--apache--4.0--8f765a1886/report.html > > >>>>>>>>>>> > > >>>>>>>>>>> * Successful Docker Image Github Actions Pipeline for 4.0 > > >>>>> branch: > > >>>>>>>>>>> Docker Build Test Pipeline (JVM): > > >>>>>>>>>>> https://github.com/apache/kafka/actions/runs/13852844456 > > >>>>>>>>>>> Docker Build Test Pipeline (Native): > > >>>>>>>>>>> https://github.com/apache/kafka/actions/runs/13853116713 > > >>>>>>>>>>> > > >>>>>>>>>>> /************************************** > > >>>>>>>>>>> > > >>>>>>>>>>> Thanks, > > >>>>>>>>>>> David Jacot > > >>>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> -- > > >>>>>>>>> David Arthur > > >>>>>>>>> > > >>>>>>>> > > >>>>>>> > > >>>>>> > > >>>>> > > >>>> > > >>> > > >> > > > > >
