Hi, Thanks for the KIP, overall it seems like a useful improvement.
A few suggestions mostly on the form: MM1: The current documentation string seems to indicate this is only used by clients. SslConfigs are used by both clients and servers. So I think the docstring should be rephrased as I expect this to be usable by both sides. Also the first sentence has an issue/typo "This is config is used". MM2: We actual code of the "applyAliasToKM()" method is not important in the KIP. The main goals of a KIP are to describe the motivation, the actual changes to the public APIs and the compatibility implications for users. The code will be discussed in the pull request. For example instead of having the code, I'd rather have a description of what happens if you provide an alias that does not exist, the error conditions are part of the changes. MM3: In the "Test Plan" section you need to describe the testing you plan to have in the Apache Kafka code base when adding the feature. All changes need to be covered by tests. Considering the small scope of the proposal, you can probably just say something like "This will be tested using unit and integration tests" but it's important to understand you'll need to write some tests. Saying "it works in my environment" is not acceptable. Thanks, Mickael On Tue, Mar 4, 2025 at 2:12 PM Rahul Nirgude <rahul.nirg...@mastercard.com.invalid> wrote: > Hi All, > > > > I would like to start a discussion on our KIP for *Support keystore with > multiple alias entries*. Please find the below KIP details. > > *KIP-1117* : > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1117%3A+Support+keystore+with+multiple+alias+entries > . > > > > Please review it and share your inputs on this. > > > > > > > > *Rahul Nirgude* > > Senior Software Engineer > > > > Mastercard > > Business Bay | Tower A > > tel - | mobile 8793830455 > > <http://www.mastercard.com> > > > CONFIDENTIALITY NOTICE This e-mail message and any attachments are only > for the use of the intended recipient and may contain information that is > privileged, confidential or exempt from disclosure under applicable law. If > you are not the intended recipient, any disclosure, distribution or other > use of this e-mail message or attachments is prohibited. If you have > received this e-mail message in error, please delete and notify the sender > immediately. Thank you. >
