Hi Sudesh, Thanks for the KIP. The existing commit method is... not great. I think the word "futile" you chose in the KIP is putting it lightly.
The new interface looks clean, implementation seems extremely straightforward, and everything's backwards compatible. The only comment I'll leave is that we should probably document what the expected behavior is if a task throws from this new method. I'm guessing the task will fail but let me know if you have other thoughts. Cheers, Chris On Tue, Apr 8, 2025, 11:20 Sudesh Wasnik <wasnik...@gmail.com> wrote: > Hi all, > I would like to discuss KIP-1158. > > This KIP introduces a new "commit()" method in KafkaConnect SourceTask > interface, primarily for use-cases where SourceConnectors need to > track "source-offset" commits. > > Thanks in advance for reviewing ! > KIP : > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=347933317 > > Thanks, > Sudesh >
