Hi All, The code has been completed a while back for metrics. I have removed MessageConversionsPerSec metric from KIP as that's not needed for ShareFetch, no conversion happens. Also the metrics RequestTopicPartitionsFetchRatio and FetchLockRatio which are histogram and meter respectively, though still represents ratio but as percentage because only int or long can be recorded for histogram and meter.
Regards, Apoorv Mittal On Fri, Nov 15, 2024 at 9:28 AM Apoorv Mittal <apoorvmitta...@gmail.com> wrote: > Thanks everyone for the feedback and votes! > > I have added the voting thread on the KIP as mentioned by Chia, also > renamed group_name to group_id as mentioned by Andrew. > > The KIP-1103 has passed with 4 binding votes (Chia, Jun, Manikumar and > David A) > and 1 non-binding vote (Andrew). > > Regards, > Apoorv Mittal > > > On Fri, Nov 15, 2024 at 1:21 AM David Arthur <mum...@gmail.com> wrote: > >> Apoorv, thanks for the KIP! >> >> I appreciate the rationale section, it made this quite easy to follow and >> understand. >> >> +1 binding >> >> -David A >> >> On Thu, Nov 14, 2024 at 1:43 AM Manikumar <manikumar.re...@gmail.com> >> wrote: >> >> > Hi Apoorv, >> > >> > Thanks for the KIP. >> > >> > +1 (binding) >> > >> > Thanks >> > >> > On Thu, Nov 14, 2024 at 11:11 AM Chia-Ping Tsai <chia7...@apache.org> >> > wrote: >> > >> > > hi Apoorv >> > > >> > > Could you please add the link of vote thread to the KIP-1103 page? >> > > >> > > thanks, >> > > Chia-Ping >> > > >> > > On 2024/11/07 11:14:03 Apoorv Mittal wrote: >> > > > Hi All, >> > > > I would like to start vote on KIP-1103: >> > > > >> > > >> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1103%3A+Additional+metrics+for+cooperative+consumption >> > > > >> > > > Discussion thread: >> > > > https://lists.apache.org/thread/cfh2n46918b573vqlqj3v7q06nsyorb5 >> > > > >> > > > Regards, >> > > > Apoorv Mittal >> > > > >> > > >> > >> >> >> -- >> David Arthur >> >
