[
https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133259#comment-14133259
]
Neha Narkhede commented on KAFKA-1282:
--------------------------------------
Thanks for the patch, [~nmarasoi]! Looks good overall. Few review comments -
1. Do we really need connectionsLruTimeout in addition to connectionsMaxIdleMs?
It seems to me that we are translating the idle connection timeout plugged in
by the user to 1000000x times more than what is configured. That's probably why
Jun saw the behavior he reported earlier.
2. I don't really share Jun's concern in #2 and we can state that more clearly
in the comment that describes the new config in KafkaConfig. Connections that
are idle for more than connections.max.idle.ms *may* get killed. I don't think
the users particularly care about a hard guarantee of their connections getting
killed here. So the simplicity of this approach is well justified.
3. I do think that adding a produce and fetch test where the connections get
killed will be great
> Disconnect idle socket connection in Selector
> ---------------------------------------------
>
> Key: KAFKA-1282
> URL: https://issues.apache.org/jira/browse/KAFKA-1282
> Project: Kafka
> Issue Type: Bug
> Components: producer
> Affects Versions: 0.8.2
> Reporter: Jun Rao
> Assignee: Neha Narkhede
> Labels: newbie++
> Fix For: 0.9.0
>
> Attachments:
> KAFKA-1282_Disconnect_idle_socket_connection_in_Selector.patch,
> idleDisconnect.patch
>
>
> To reduce # socket connections, it would be useful for the new producer to
> close socket connections that are idle. We can introduce a new producer
> config for the idle time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
